Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 48F26431FB6 for ; Thu, 19 Jan 2012 13:22:32 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.201 X-Spam-Level: X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FJubmxW89O1p for ; Thu, 19 Jan 2012 13:22:31 -0800 (PST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 99B41431FAF for ; Thu, 19 Jan 2012 13:22:31 -0800 (PST) Received: by werp13 with SMTP id p13so385902wer.26 for ; Thu, 19 Jan 2012 13:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=mhn12XbU0bnVr38PdRKZ1fjQgTrCgx0CKs5sf3ld+gU=; b=mfjTOuvkeo7gvKx0dba5mpPoE4VevHK/NMRerj8u9OQokZPqZYfxotCXRZxJyscHL+ qBT1Bru08vGWdG0dGqFmWziOFqROoB5xgAyz+vdgclIav8aUNFW1I2bL0yzuplrkU2Gb knZ49sbaDJcJGYRbhrn1EeNDMV/LEeHQA1354= Received: by 10.216.139.156 with SMTP id c28mr1301731wej.34.1327008150553; Thu, 19 Jan 2012 13:22:30 -0800 (PST) Received: from localhost (94-192-233-223.zone6.bethere.co.uk. [94.192.233.223]) by mx.google.com with ESMTPS id r1sm30193756wia.8.2012.01.19.13.22.29 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 19 Jan 2012 13:22:29 -0800 (PST) From: Mark Walters To: notmuch@notmuchmail.org Subject: [PATCH v4 0/1] Date: Thu, 19 Jan 2012 21:23:04 +0000 Message-Id: <1327008185-21194-1-git-send-email-markwalters1009@gmail.com> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: References: X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2012 21:22:32 -0000 Here is a new version of the patch incorporating all the review comments. I have rebased it on master so, in particular, it fits into the recently committed customization framework. To deal with one corner case I decided to go with Austin's suggestion of using lexical-let as it is probably more robust to changes in mm-decode. I would like to thank him for all his other help improving my original patch. It passes the test-suite and all cases I can think of work correctly. Best wishes Mark Mark Walters (1): Make buttons for attachments allow viewing as well as saving emacs/notmuch-show.el | 116 ++++++++++++++++++++++++++++++++++++++---------- 1 files changed, 92 insertions(+), 24 deletions(-) -- 1.7.2.3