Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E36F8429E43 for ; Mon, 16 Jan 2012 03:35:42 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AHAO0GaQo0PN for ; Mon, 16 Jan 2012 03:35:42 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 5DAA2429E40 for ; Mon, 16 Jan 2012 03:35:42 -0800 (PST) Received: by wgbdr13 with SMTP id dr13so94269wgb.2 for ; Mon, 16 Jan 2012 03:35:41 -0800 (PST) Received: by 10.180.100.200 with SMTP id fa8mr17195000wib.8.1326713741211; Mon, 16 Jan 2012 03:35:41 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id gf8sm21906537wbb.11.2012.01.16.03.35.39 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Jan 2012 03:35:40 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 206E19FD88; Mon, 16 Jan 2012 11:35:38 +0000 (GMT) To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH 1/4] emacs: unify search mechanisms In-Reply-To: <1324786495-14221-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1324786495-14221-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Mon, 16 Jan 2012 11:35:37 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 11:35:43 -0000 --=-=-= Content-Type: text/plain On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin wrote: > Before the change, there were two ways to do search in Emacs UI: > search widget in notmuch-hello buffer and `notmuch-search' > function bound to "s". Internally, notmuch-hello search widget > uses `notmuch-search' function. But it uses widget field input > instead of minibuffer. Such duplication is a major issue for > notmuch-hello usability: search interface is inconsistent and > lacks features that are available in minibuffer (e.g. history and > auto completion). Some of these features may be relatively easy > to implement for notmuch-hello search, others would be much more > tricky. So to avoid duplication, make UI more consistent, bring > notmuch-hello search to feature parity with the minibuffer > search, the patch replaces notmuch-hello search widget and with a > button that works the same way as "s" key binding. Dmitry, if Daniel re-submits his patches to allow the construction of `notmuch-hello' buffers to be configured, it seems that this patchset would become unnecessary. Is that correct? --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8UC4kACgkQaezQq/BJZRYHrwCfagnuF8CFLbS4ujujtfJjDXPG cw0An2o2GUeKq22KnoJV+2dZvWEXFx6Z =kwtp -----END PGP SIGNATURE----- --=-=-=--