From: Carl Worth <cworth@cworth.org>
To: Alexander Botero-Lowry <alex.boterolowry@gmail.com>,
	notmuch@notmuchmail.org
In-Reply-To:
 <86bpid10h1.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me>
References:
 <86bpid10h1.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me>
Date: Mon, 07 Dec 2009 09:53:33 -0800
Message-ID: <87d42qvffm.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Subject: Re: [notmuch] slowdown with large html heavy threads
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Sat, 05 Dec 2009 15:10:18 -0800, Alexander Botero-Lowry <alex.boterolowr=
y@gmail.com> wrote:
> Carl mentioned that he saw some nasty performance issues with threads
> that had a lot of HTML messages in them.
>=20
> If you are experiencing this problem, would you mind trying some
> alternative mm-text-html-renderer setting:
>=20
> http://mh-e.sourceforge.net/manual/html/HTML.html
>=20
> Also, if you have elinks, I recommend my custom renderer:
>=20
> (require 'mm-view)
> (add-to-list 'mm-text-html-renderer-alist=20
>   '(elinks mm-inline-render-with-stdin nil "elinks" "-force-html" "-dump"=
))
> (setq mm-text-html-renderer 'elinks)

Hi Alex,

I'm sorry, but the delays got in my way so much this morning that I
reverted the patch before even attempting the alternate renderer.

Part of my annoyance may have been due to a distinct bug. There was
definitely one instance where I was seeing a big delay when trying to
display a tiny thread (about 13 messages) none of which were HTML. I
reverted the HTML-rendering patch and saw the delay go away, but I also
put the patch back and didn't see the problem come back.

So that problem might have been form something else. But when I looked
at the patch and saw that it was doing this:

=2D            (let ((filename (notmuch-show-get-filename)))
=2D              (with-temp-buffer
=2D                (insert-file-contents filename nil nil nil t)

for every file, (regardless of it being HTML or not), I was convinced
that there's got to be a better way. Notmuch has already passed the
entire thread through GMime, so we really don't want to do a second pass
of all of the raw message content through an emacs-lisp MIME parser as
well.

Instead, let's find a way to just get the information from GMime to be
cheaply available for emacs to look at (without loading all of the
original files).

=2DCarl


--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLHUEe6JDdNq8qSWgRAoSrAJ4xWJCqU+5KzlMw2qDIeWxyNzAe1gCfbcA9
FkICm7CqfcMjJ3ey6TK/Pcc=
=hJO7
-----END PGP SIGNATURE-----
--=-=-=--