Date: Tue, 15 Jul 2014 10:14:07 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Sime Ramov <sramov@pobox.com>
Subject: Re: notmuch-reply date format
Message-ID: <20140715141407.GF4660@mit.edu>
References: <1722345767858996112.enqueue@ouroboros.ramov.inet>
	<20140714130431.GB4660@mit.edu>
	<702358554056882337.enqueue@ouroboros.ramov.inet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <702358554056882337.enqueue@ouroboros.ramov.inet>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth Sime Ramov on Jul 15 at  9:35 am:
> Hello,
> 
> * Austin Clements <amdragon@MIT.EDU> [Mon, 14 Jul 2014 09:04:31 -0400]:
> > Assuming the CLI is the right place for you to change this, you
> > probably want to call notmuch_message_get_date, then localtime, then
> > strftime.
> 
> Tried to get this working to no avail. Not a programmer obviously :) I
> cobbled this together from various online sources:
> 
> diff --git a/notmuch-reply.c b/notmuch-reply.c
> index 7c1c809..16cf19c 100644
> --- a/notmuch-reply.c
> +++ b/notmuch-reply.c
> @@ -44,9 +44,15 @@ format_part_reply (mime_node_t *node)
>      int i;
>  
>      if (node->envelope_file) {
> -	printf ("On %s, %s wrote:\n",
> -		notmuch_message_get_header (node->envelope_file, "date"),
> -		notmuch_message_get_header (node->envelope_file, "from"));
> +	struct tm *info;
> +	char dbuf[30];
> +
> +	info = localtime(notmuch_message_get_date(node->envelope_file));

Close.  For whatever reason, localtime takes a pointer to a time_t,
not a time_t (even though time_t is just a number).  You'll need
something like

time_t date;

date = notmuch_message_get_date(node->envelope_file);
info = localtime(&date);

> +
> +	strftime(dbuf, sizeof(dbuf), "%F %R %z", info);
> +	printf ("* %s [%s]:\n",
> +		notmuch_message_get_header(node->envelope_file, "from"), dbuf);
> +
>      } else if (GMIME_IS_MESSAGE (node->part)) {
>  	GMimeMessage *message = GMIME_MESSAGE (node->part);
>  	InternetAddressList *recipients;
> 
> When compiling I get this warning:
> 
> notmuch-reply.c: In function 'format_part_reply':
> notmuch-reply.c:50: warning: passing argument 1 of 'localtime' makes pointer from integer without a cast

Ah, C.  "I'm sure they meant for that number that looks nothing like a
pointer to actually be a pointer that could corrupt memory, disclose
private information, or crash the program.  I'll just convert it for
them real quick..."

> And a core dump when notmuch reply is invoked on a message. Am I even
> close? :) Thanks