Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C0993431FD0 for ; Mon, 31 Oct 2011 03:51:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5M5xBFs0fXu0 for ; Mon, 31 Oct 2011 03:51:20 -0700 (PDT) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 23DD2431FB6 for ; Mon, 31 Oct 2011 03:51:20 -0700 (PDT) Received: from zancas.localnet (fctnnbsc36w-156034064058.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.64.58]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p9VApElQ026349 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 31 Oct 2011 07:51:15 -0300 Received: from bremner by zancas.localnet with local (Exim 4.76) (envelope-from ) id 1RKpSU-0002ic-As; Mon, 31 Oct 2011 07:51:14 -0300 From: David Bremner To: Jani Nikula Subject: Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. In-Reply-To: <877h3ly0tu.fsf@nikula.org> References: <1319383133-11006-1-git-send-email-david@tethera.net> <877h3ly0tu.fsf@nikula.org> User-Agent: Notmuch/0.9+26~g4e49596 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 31 Oct 2011 07:51:14 -0300 Message-ID: <874nypqvrx.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2011 10:51:20 -0000 On Mon, 31 Oct 2011 09:20:13 +0000, Jani Nikula wrote: > > Hi David, this patch (commit 1dedfc90f6eee7cad10f1a1ceb39a7a1c4dbd1b1) > broke my build with: > > CXX -O2 lib/libnotmuch.so.2.0.0 Can you try "make V=1"? The output should look like g++ lib/filenames.o lib/string-list.o lib/libsha1.o lib/message-file.o lib/messages.o lib/sha1.o lib/tags.o lib/database.o lib/directory.o lib/index.o lib/message.o lib/query.o lib/thread.o -Wl,--as-needed -pthread -lgmime-2.4 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0 -ltalloc -lxapian -shared -Wl,--version-script=notmuch.sym,-soname=libnotmuch.so.2 -o lib/libnotmuch.so.2.0.0 -L./util -lutil The last part, "-L./util -lutil" is where all those symbols are. d