Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 42748431FBC for ; Wed, 10 Feb 2010 09:54:49 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.246 X-Spam-Level: X-Spam-Status: No, score=-0.246 tagged_above=-999 required=5 tests=[AWL=-0.247, BAYES_50=0.001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bNcYRH47tI+d for ; Wed, 10 Feb 2010 09:54:48 -0800 (PST) Received: from julia.quadhome.com (quadhome.xen.prgmr.com [68.68.99.250]) by olra.theworths.org (Postfix) with ESMTP id 9F865431FAE for ; Wed, 10 Feb 2010 09:54:48 -0800 (PST) Received: from elise.quadhome.com (150.59.148.190.dsl.intelnet.net.gt [190.148.59.150]) by julia.quadhome.com (Postfix) with ESMTPSA id B77DE5FA92 for ; Wed, 10 Feb 2010 17:54:47 +0000 (UTC) Content-Type: text/plain; charset=UTF-8 From: Scott Robinson To: notmuch In-reply-to: <87mxzhjj0s.fsf@rocinante.cs.unb.ca> References: <1262272660-16786-1-git-send-email-david@tethera.net> <87mxzhjj0s.fsf@rocinante.cs.unb.ca> Date: Wed, 10 Feb 2010 11:54:45 -0600 Message-Id: <1265824234-sup-8219@elise> User-Agent: Sup/0.10.2 Content-Transfer-Encoding: 8bit Subject: Re: [notmuch] [PATCH] Add an "--format=(json|text)" command-line option to both notmuch-search and notmuch-show. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2010 17:54:49 -0000 Excerpts from David Bremner's message of Wed Feb 10 07:51:47 -0600 2010: > Dear Scott and other interested parties; > > As I play with json output a bit more, it seems like having > --entire-thread optional would be useful for quite a few applications. > For example, if I want to get the From address for a given message-ID, I > with the current setup I have to post process the output. This is > doable, but I wonder if the better option isn't to make --entire-thread > optional for --format=json as well. > > Any thoughts? I made --entire-thread forced becuase it kept the JSON patch minimal. The way the thread structure is calculated is closely tied into the message tree recursion. It would have required a much more significant refactoring to get both ways; and, I wanted the patch to have as few barriers to being merged. However, as patch still hasn't been merged and probably needs to be rebased, there doesn't seem to be any good reason anymore to avoid the work. Except, I can't do it. As I noted in an earlier e-mail, I have to abandon this piece of code. I'm a bit busy backpacking through Central America. :-)