Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4B3904196F0 for ; Sat, 29 May 2010 11:02:03 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[BAYES_20=-0.001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ff1WDL4X4dNB for ; Sat, 29 May 2010 11:01:53 -0700 (PDT) Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU [18.9.25.14]) by olra.theworths.org (Postfix) with ESMTP id 1D82C431FC1 for ; Sat, 29 May 2010 11:01:53 -0700 (PDT) X-AuditID: 1209190e-b7b82ae000005260-8f-4c01568f6648 Received: from mailhub-auth-4.mit.edu (MAILHUB-AUTH-4.MIT.EDU [18.7.62.39]) by dmz-mailsec-scanner-3.mit.edu (Symantec Brightmail Gateway) with SMTP id E9.72.21088.F86510C4; Sat, 29 May 2010 14:01:51 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id o4TI1ovS030186; Sat, 29 May 2010 14:01:51 -0400 Received: from localhost (DR-WILY.MIT.EDU [18.181.0.233]) (authenticated bits=0) (User authenticated as davidben@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id o4TI1nIQ011736; Sat, 29 May 2010 14:01:50 -0400 (EDT) Date: Sat, 29 May 2010 14:01:49 -0400 (EDT) From: David A Benjamin To: Christopher League Subject: Re: [PATCH] quoting message-IDs for the shell In-Reply-To: <87bpbztwcy.fsf@contrapunctus.net> Message-ID: References: <87bpbztwcy.fsf@contrapunctus.net> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Brightmail-Tracker: AAAAARRlSuo= Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 May 2010 18:02:03 -0000 On Fri, 28 May 2010, Christopher League wrote: > @@ -915,7 +919,7 @@ to stdout or stderr will appear in the *Messages* buffer." > (apply 'notmuch-call-notmuch-process > (append (cons "tag" > (mapcar (lambda (s) (concat "+" s)) toadd)) > - (cons (notmuch-show-get-message-id) nil))) > + (cons (notmuch-show-quoted-message-id) nil))) > (notmuch-show-set-tags (sort (union toadd (notmuch-show-get-tags) :test 'string=) 'string<))) > > (defun notmuch-show-remove-tag (&rest toremove) > @@ -929,7 +933,7 @@ to stdout or stderr will appear in the *Messages* buffer." > (apply 'notmuch-call-notmuch-process > (append (cons "tag" > (mapcar (lambda (s) (concat "-" s)) toremove)) > - (cons (notmuch-show-get-message-id) nil))) > + (cons (notmuch-show-quoted-message-id) nil))) > (notmuch-show-set-tags (sort (set-difference tags toremove :test 'string=) 'string<)))))) > Hrm. Are you sure? notmuch-call-notmuch-process is implemented using call-process, which doesn't seem to invoke the shell. David Benjamin