From: Mark Walters <markwalters1009@gmail.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: show: make id links respect window
In-Reply-To: <87bodjfnt0.fsf@zancas.localnet>
References: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com>
	<87bodjfnt0.fsf@zancas.localnet>
User-Agent: Notmuch/0.14+236~g1d0044f (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Tue, 25 Dec 2012 11:04:39 +0000
Message-ID: <87mwx2jsu0.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


On Mon, 24 Dec 2012, David Bremner <david@tethera.net> wrote:
> Mark Walters <markwalters1009@gmail.com> writes:
>
>> I think this is a bug but that could be debated. It is particularly
>> easy to trigger with notmuch pick because that uses the split pane
>> while focus usually remains in the `pick' pane rather than the `show'
>> pane.
>
> I can imagine that people would want/like the "open in other window" 
> effect of the current code, even if the reason is a bug.

That's definitely possible. I generally expect a mouse click to select
the window I click and this feels counter intuitive. I think that some
people might like an option "open this link in a new window" but I would
guess that would like that whether they clicked or pressed RET on the
button.

>>  			  'action `(lambda (arg)
>>  				     (notmuch-show ,(third link)))

> Can you (or someone) explain why backquote is needed here? Is this some
> kind of workaround for lack of lexical scope? If so, maybe a comment.

I think this is a reasonably standard use: we want "(third link)"  to be
evaluated when the button is made, but we want the rest of the action to
be evaluated when the action is called. 

Best wishes

Mark

>
> d