From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH 8/6] emacs: use message ids instead of thread id in
	`notmuch-show-operate-all'
In-Reply-To: <20120129231120.GJ17991@mit.edu>
References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1327730348-6466-1-git-send-email-dmitry.kurochkin@gmail.com>
	<20120129231120.GJ17991@mit.edu>
User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 30 Jan 2012 05:50:14 +0400
Message-ID: <87y5sq6js9.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

EOn Sun, 29 Jan 2012 18:11:20 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Eighth in the increasingly inaccurately named six patch series...
> 
> Quoth Dmitry Kurochkin on Jan 28 at  9:59 am:
> > Before the change, `notmuch-show-operate-all' used thread id for
> > "notmuch tag" search.  This could result in tagging unexpected
> > messages that were added to the thread after the notmuch-show buffer
> > was created.  The patch changes `notmuch-show-operate-all' to use ids
> > of shown messages to fix this.
> 
> Are you planning to roll this into your earlier patch?
> 

I would prefer to leave it separate.

> > ---
> >  emacs/notmuch-show.el |   23 ++++++++++++++++++++++-
> >  1 files changed, 22 insertions(+), 1 deletions(-)
> > 
> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > index 2ca4d92..e606224 100644
> > --- a/emacs/notmuch-show.el
> > +++ b/emacs/notmuch-show.el
> > @@ -1170,6 +1170,15 @@ All currently available key bindings:
> >      (notmuch-show-move-to-message-top)
> >      t))
> >  
> > +(defun notmuch-show-mapc (function)
> > +  "Iterate through all messages with
> > +`notmuch-show-goto-message-next' and call `function' for side
> > +effects."
> 
> `function' should be FUNCTION.
> 

done

> > +  (save-excursion
> > +    (goto-char (point-min))
> > +    (loop do (funcall function)
> > +	  while (notmuch-show-goto-message-next))))
> > +
> >  ;; Functions relating to the visibility of messages and their
> >  ;; components.
> >  
> > @@ -1222,6 +1231,18 @@ Some useful entries are:
> >    "Return the message id of the current message."
> >    (concat "id:\"" (notmuch-show-get-prop :id) "\""))
> >  
> > +(defun notmuch-show-get-messages-ids ()
> > +  "Return all message ids of currently shown messages."
> 
> "currently shown" could mean visible on the screen, which is not what
> you mean.  You also don't mean "open messages".  Maybe "Return all
> message ids of messages in this show buffer"?
> 

Changed to "messages in the current thread".  That is consistent with
other docstrings in notmuch-show.el.

> > +  (let ((message-ids))
> > +    (notmuch-show-mapc
> > +     (lambda () (push (notmuch-show-get-message-id) message-ids)))
> > +    message-ids))
> > +
> > +(defun notmuch-show-get-messages-ids-search ()
> > +  "Return a search string for all message ids of currently shown
> > +messages."
> 
> Same.
> 

fixed

Regards,
  Dmitry

> > +  (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))
> > +
> >  ;; dme: Would it make sense to use a macro for many of these?
> >  
> >  (defun notmuch-show-get-filename ()
> > @@ -1496,7 +1517,7 @@ i.e. a list of tags to change with '+' and '-' prefixes."
> >  `Changed-tags' is a list of tag operations for \"notmuch tag\",
> >  i.e. a list of tags to change with '+' and '-' prefixes."
> >    (interactive (notmuch-select-tags-with-completion nil notmuch-show-thread-id))
> > -  (apply 'notmuch-tag notmuch-show-thread-id changed-tags)
> > +  (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) changed-tags)
> >    (save-excursion
> >      (goto-char (point-min))
> >      (loop do (let* ((current-tags (notmuch-show-get-tags))