Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 29207431FC2 for ; Sat, 29 Nov 2014 08:40:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ek-UN4LK0wPe for ; Sat, 29 Nov 2014 08:40:27 -0800 (PST) Received: from smtp2.cs.Stanford.EDU (smtp2.cs.stanford.edu [171.64.64.26]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 8788A431FBF for ; Sat, 29 Nov 2014 08:40:27 -0800 (PST) Received: from [154.35.132.83] (port=60095 helo=Jane.lan) by smtp2.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128) (Exim 4.80.1) (envelope-from ) id 1Xul4K-0001w4-Au; Sat, 29 Nov 2014 08:40:25 -0800 From: Charles Celerier To: David Bremner , David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Added "is:" style completion to notmuch-read-query. In-Reply-To: <87wq6ectxm.fsf@maritornes.cs.unb.ca> References: <1417219835-92141-1-git-send-email-cceleri@cs.stanford.edu> <87wq6ectxm.fsf@maritornes.cs.unb.ca> User-Agent: Notmuch/0.18.1+208~g6302bf1 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-apple-darwin14.0.0) Date: Sat, 29 Nov 2014 11:40:16 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Scan-Signature: dcedbbeaec314583a5a6d4e37e27e533 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Nov 2014 16:40:36 -0000 --=-=-= Content-Type: text/plain Just updated the patch to use lexical-let as suggested. I'm not too familiar with emacs-lisp, so please tell me if you had something else in mind. charles David Bremner writes: > David Edmondson writes: > >> On Sat, Nov 29 2014, Charles Celerier wrote: > >> >> Should use a `let' binding rather than `setq'. Otherwise, looks good. >> >>> (lexical-let >>> ((completions >>> (append (list "folder:" "path:" "thread:" "id:" "date:" "f > > What about using lexical-let* to combine the two binding forms? > > d --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2 iQEcBAEBAgAGBQJUefbwAAoJEOjk698fDjuAfTsH/jmapR98e8Q3YJba8ODWMuK6 CgQictnu0b3d6vWWVlo1kuq9bDUEiyGFbEApBAOzUEel+gdssuzZekZVRhE+xWTq 0ioLLj5Dyzzh3IZNB7NStQ6n1CGvXEhJbpCEo4F/TlrnuVnJlq1wNwVE7an2C/De vHNT6gRmRZKt5KBShEjo3O/TXROqsScrzfX3sRX4RDaJiCawc6WOdfnzb85Bq/LF 0mYU8cyRLHzn1OhU8jYUmW997byBVihYnjmfpL+lQNQUO5zOqAQ1IPP37rIPu1ix nCcoKhkFBHNUuy78pMkpFZc8gBiUUx2K17Q58pyVyiMDzX+RuGXDhWN1cSwQ9Z0= =zT/h -----END PGP SIGNATURE----- --=-=-=--