From: Carl Worth <cworth@cworth.org>
To: Austin Clements <amdragon@mit.edu>,
	Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Subject: Re: [PATCH] Save and restore point explicitly in
	`notmuch-wash-toggle-invisible-action'.
In-Reply-To: <BANLkTi=_PszwPDRbRxVpVhkT=YRAi5dGDQ@mail.gmail.com>
References: <1306090675-26982-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1306164587-20326-1-git-send-email-dmitry.kurochkin@gmail.com>
	<87oc2rlujb.fsf@yoom.home.cworth.org> <8762ozrfrr.fsf@gmail.com>
	<87oc2rvjvj.fsf@yoom.home.cworth.org> <871uznrbh5.fsf@gmail.com>
	<BANLkTi=_PszwPDRbRxVpVhkT=YRAi5dGDQ@mail.gmail.com>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Tue, 24 May 2011 15:57:32 -0700
Message-ID: <87fwo3btb7.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=

On Tue, 24 May 2011 18:43:41 -0400, Austin Clements <amdragon@mit.edu> wrote:
> Saving point this way is a bit dangerous, though.  For example, if
> you're near the end of the buffer and shorten the label, attempting to
> restore the point could result in an error (or, a more benign example:
> the cursor could wind up outside the label so pressing RET repeatedly
> won't toggle it).

Without the patch to change save-excursion to an integer, point is
already moving outside the button, (so that repeatedly pressing RET
doesn't toggle).

I'm exploring a proper fix now to get reliable behavior.

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk3cN9wACgkQ6JDdNq8qSWg0IACgoMLhCretCpHFc85vRwuJiDw3
CggAn3CIKV/iHpqQ2VggjeaTgn58AEka
=Q5Ni
-----END PGP SIGNATURE-----
--=-=-=--