From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Mike Kelly <pioto@pioto.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/4] Maildir synchronization v2
In-Reply-To: <20101018101231.69904381@pioto.org>
References: <1286972038-21064-1-git-send-email-sojkam1@fel.cvut.cz>
	<20101018101231.69904381@pioto.org>
User-Agent: Notmuch/0.3.1-110-g7be1648 (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Fri, 22 Oct 2010 06:43:27 +0200
Message-ID: <8739ryltw0.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Mon, 18 Oct 2010, Mike Kelly wrote:
> Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> > they are ready to be merged. They can be pulled by:
> > 
> > git pull git://rtime.felk.cvut.cz/notmuch maildir-sync-v2
> 
> I've tested these patches on Linux, and they seem to work as expected.
> However, I'd like to suggest/request that the level-4 syncing of a
> filename should happen in notmuch_(message|thread)_(add|remove)_tag(),
> not in notmuch-tag.cc. Otherwise, anyone using libnotmuch directly
> (e.g. alternative clients, things using python bindings, etc) will not
> benefit from this.

Hi, I'd agree but these pathes don't touch notmuch-tag.c in a
significant way. What's done there is to read the value from config and
to call a function (from libnotmuch) to setup an internal variable
accordingly. Other users of libnotmuch have probably different means of
configuration than notmuch itself and should call this function in a
similar way.

-Michal