From: Mark Walters <markwalters1009@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 3/3] emacs: Don't insert a part header if it's the
	first part and text/*.
In-Reply-To: <1328542748-19530-5-git-send-email-dme@dme.org>
References: <1327052612-1040-1-git-send-email-dme@dme.org>
	<1328542748-19530-1-git-send-email-dme@dme.org>
	<1328542748-19530-5-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.11.1+172~g6a5d2c5 (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Sun, 12 Feb 2012 09:24:09 +0000
Message-ID: <87r4y0ieva.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Mon,  6 Feb 2012 15:39:08 +0000, David Edmondson <dme@dme.org> wrote:
> Previously this logic applied only to text/plain. Allow it for other
> text/* parts as well.

What is the reason for treating the first part differently? 

Personally, I would prefer to keep it as now since pressing v on the
[text/html] `views' the message in my mailcap preferred html viewer
which can be convenient.

Thanks

Mark


> ---
>  emacs/notmuch-show.el |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index ce79762..c60e613 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -412,7 +412,9 @@ CONTENT-TYPE parts."
>  (defun notmuch-show-insert-part-header (nth content-type declared-type
>  					    &optional name comment
>  					    &rest button-parameters)
> -  (unless (notmuch-show-hidden-part-header content-type)
> +  (unless (or (notmuch-show-hidden-part-header content-type)
> +	      (and (= nth 1)
> +		   (string-match "text/*" content-type)))
>      (apply #'insert-button
>  	   (concat "[ "
>  		   (if name (concat name ": ") "")
> @@ -703,10 +705,7 @@ current buffer, if possible."
>  
>  (defun notmuch-show-insert-part-text/plain (msg part content-type nth depth declared-type)
>    (let ((start (point)))
> -    ;; If this text/plain part is not the first part in the message,
> -    ;; insert a header to make this clear.
> -    (if (> nth 1)
> -	(notmuch-show-insert-part-header nth declared-type content-type (plist-get part :filename)))
> +    (notmuch-show-insert-part-header nth declared-type content-type (plist-get part :filename))
>      (insert (notmuch-show-get-bodypart-content msg part nth))
>      (save-excursion
>        (save-restriction
> -- 
> 1.7.8.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch