Date: Fri, 24 Oct 2014 10:03:52 -0700
From: Ian Main <imain@stemwinder.org>
To: Tomi Ollila <tomi.ollila@iki.fi>, Tomi Ollila <tomi.ollila@iki.fi>,
	notmuch@notmuchmail.org
Message-ID: <544a8678c3deb_bdfbf9e886a@ovo.mains.priv.notmuch>
In-Reply-To: <m2oat177mi.fsf@guru.guru-group.fi>
References: <1414102794-12094-1-git-send-email-imain@stemwinder.org>
	<1414167094-31566-1-git-send-email-imain@stemwinder.org>
	<m2oat177mi.fsf@guru.guru-group.fi>
Subject: Re: [PATCH v3] VIM: Add URI handling
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: list

Tomi Ollila wrote:
> On Fri, Oct 24 2014, Ian Main <imain@stemwinder.org> wrote:
> 
> This patch does not apply on top of notmuchmail master 
> (commit 38240d106139da8).
> 
> > This patch adds URI handling to the vim client.  You can now press
> 
> Although insignificant, I'll start commenting on all sent patches
> (that I look into) which talk like 'This patch adds' -- sure it is patch
> when email is sent, but in repository it is not so -- so the commit message
> should not mention it (but I do not require changing it).
> 
> Anyway, I suspect this change will become applicable after some other
> change is committed first -- and IMO this could stay as non-stale patch
> provided that SomeOne(TM) informs what is the message that contains
> changes (or series those) that is required for this message to apply.
> 
> BTW: does the content of this change differ much from v1 at
> id:1412281423-22441-1-git-send-email-imain@stemwinder.org
> or should I re-check (carefully!) that the changes are still OK.
> 
> 
> Tomi
> 

This one is almost identical minus the hotkey usage.  The attachment support
patch has changed a fair bit in that it now looks at all parts of multipart
messages, giving you the opportunity to view the original text/html message
in a web browser.

I sent them out as a series in a new thread so that it would be easier to
follow.  I have them all applied locally and there were some conflicts to
resolve.  They are simple, usually around the defaults settings for the
configuration but it's still a pain.  I'm still tempted to send out all
of the outstanding patches as a big series.  All the patches posted though
should apply to master so I may just have to rebase now and again.

    Ian