From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
 Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: tree: mark read change
In-Reply-To: <87si9iyxn9.fsf@maritornes.cs.unb.ca>
References: <1433843467-32398-1-git-send-email-markwalters1009@gmail.com>
 <87si9iyxn9.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.20.1+30~g467da49 (http://notmuchmail.org) Emacs/24.3.1
 (x86_64-unknown-linux-gnu)
Date: Wed, 24 Jun 2015 00:14:02 +0300
Message-ID: <m2616eb011.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Tue, Jun 23 2015, David Bremner <david@tethera.net> wrote:

> Mark Walters <markwalters1009@gmail.com> writes:
>
>> The mark read code for tree mode did not get updated in the recent
>> changes. This updates it to match. Since the user can customize the
>> mark read logic we just call the show logic in the message pane.
>> ---
>>
>> An alternative would be to mark any message explicitly viewed in
>> tree-mode as read. That would be simpler but I think this is better as
>> it deals with user customized mark read functions -- for example if
>> the user has a customized function that only marks a message read if
>> the whole message is viewed then this version will do the same in tree
>> mode.
>
> At first I was leery of the chaining of hooks, but now that I
> noticed/experienced the bug, it makes more sense to me.  I'm considering
> rolling a bug fix release with this (I imagine the bug is pretty
> annoying for people using only notmuch-tree), so I'd like a bit more
> feedback before merging it.

>From code point of view it looks good to me.

Tomi

>
> d