Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C8B81431FB6 for ; Tue, 17 Apr 2012 02:33:53 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sNsCmSPJGD4b for ; Tue, 17 Apr 2012 02:33:50 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BAA4A431FAE for ; Tue, 17 Apr 2012 02:33:49 -0700 (PDT) Received: by lbdb5 with SMTP id b5so1776964lbd.26 for ; Tue, 17 Apr 2012 02:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=MXEupgwvwdp0h8hrPQI3T77WxadoY5RIl1op0ccB7eg=; b=qWYROo/t/qzlPALDjDJzZG3hPdpfl4oRtZnaecINB0ABwQWkezmsiGVKOOJSy1XYKh Qv+S/nDaS4JxUToJK6krUSz7vNrVwQulgDET9aDRp8mGJjFagpuAFxuKxKzrqU2sAeNT iF5lyahXuT8lCQ/vo1dHmgkhpsLEI18bv3Ss4n80k7mmwfgFP8jcZVSCJGllnyNSd5GU qpFgSRN2Z1n+LjqckZVOqtbgqfcCOw++2VGWkuJWnFY7awdPR1xx9aJqo6ldorSHEovu 1ncM9fDiYbWNDXrlWd5r/Er9PRRTAKNHygJ50ARn58ziwn3NwpG6QOGXF78BXV4c9cTz Whfw== Received: by 10.152.103.239 with SMTP id fz15mr13370977lab.42.1334655228113; Tue, 17 Apr 2012 02:33:48 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id ay4sm28181169lbb.2.2012.04.17.02.33.46 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 Apr 2012 02:33:47 -0700 (PDT) From: Dmitry Kurochkin To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook In-Reply-To: <87hawivh73.fsf@nikula.org> References: <21f129a3426c58d44fed7150b32c4fec7021bda0.1334651669.git.jani@nikula.org> <877gxeohh6.fsf@gmail.com> <87hawivh73.fsf@nikula.org> User-Agent: Notmuch/0.12+104~gf9ad237 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Tue, 17 Apr 2012 13:31:57 +0400 Message-ID: <87y5pun1pu.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2012 09:33:53 -0000 Jani Nikula writes: > On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin wrote: >> Can you please give some explanaition why is this needed? Would this >> change break custom hooks that do not expect any arguments? > > For patch 3/4. We don't want to display a message if someone calls > (notmuch-hello-update t) from some script, and notmuch-hello buffer > isn't even visible. > > Yes, it would break custom hooks. And a bunch of tests. But I think it > would be useful for custom hooks too, for the same reason as above. > Makes sense. I think it should be mentioned in the commit message. Especially the fact that it breaks existing hooks. We should mention it in the NEWS later as well. Regards, Dmitry > Jani. > > > >> >> Regards, >> Dmitry >> >> Jani Nikula writes: >> >> > --- >> > emacs/notmuch-hello.el | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el >> > index 9cd907a..0596bbe 100644 >> > --- a/emacs/notmuch-hello.el >> > +++ b/emacs/notmuch-hello.el >> > @@ -776,7 +776,7 @@ following: >> > (widget-setup) >> > >> > (goto-char final-target-pos)) >> > - (run-hooks 'notmuch-hello-refresh-hook) >> > + (run-hook-with-args 'notmuch-hello-refresh-hook no-display) >> > (setq notmuch-hello-first-run nil)) >> > >> > (defun notmuch-folder () >> > -- >> > 1.7.1 >> > >> > _______________________________________________ >> > notmuch mailing list >> > notmuch@notmuchmail.org >> > http://notmuchmail.org/mailman/listinfo/notmuch