From: Jameson Graef Rollins <jrollins@finestructure.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles
In-Reply-To: <1327941064-20027-1-git-send-email-dme@dme.org>
References: <1327486729-18052-1-git-send-email-dme@dme.org>
	<1327941064-20027-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.11+128~g6f388fa (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 30 Jan 2012 09:47:34 -0800
Message-ID: <87pqe1w095.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 30 Jan 2012 16:30:59 +0000, David Edmondson <dme@dme.org> wrote:
> v3:
>  - Add a toggle for line truncation (>).
>  - Retain the state of a show buffer across a call to refresh (which
>    includes the various toggles here).
>=20
> David Edmondson (5):
>   emacs: Rework crypto switch toggle.
>   emacs: Allow `notmuch-show-mode' to display only matching messages.
>   emacs: Allow the indentation of content to be toggled.
>   emacs: Add a binding (>) to toggle the truncation of long lines.
>   emacs: Retain the state of the buffer during
>     `notmuch-show-refresh-view'.
>=20
>  emacs/notmuch-show.el |  183 +++++++++++++++++++++++++++++++++----------=
------
>  emacs/notmuch.el      |    7 +-
>  2 files changed, 126 insertions(+), 64 deletions(-)

Still testing, but so far works great.  Again, this is=20

One thing I've noticed, which isn't actually part of this patch, is that
the long-line truncation doesn't respect the indentation, which makes
things look strange.

But honestly I still don't like our method of displaying threads as a
giant chain of concatenated messages with indentation.  But that's for
later work.

Again, I haven't done a code review yet, but so far this seems to work
like a charm.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPJte2AAoJEO00zqvie6q8UoQP/1hG8w1wiaCQbBHGEx9iK9F8
k4MMBar/eWYzGnXdKy0dWCkeJY5GQk4wT+e5dLmHrgDtddJbT/ZZbdIFoRYM3U6h
AHtdSI0Nn6SW0RK5mItWOE1TSZUcH5qBOsWlGaYcsCUt1s/HFThcFNUoKz4Zgnwg
0jo+KO+BtDWO1MEVnIQUdC0u+OW+TsU0scA2Bkzhn41+6SJC4tBYs79p16dM4okQ
Zta5lbLLxeYXg2nHCu4s/LZbj4kPqltKFmKFbkA2IxtSk6ITg4TWAEOMQZygKd2s
lOftx2W2svx2VUm0zO2jecTqF/DlJwNpzzKpZ315iUG5kJ4k8vHCYcAaBVhzqriu
q56hlWrvlG9FVStn3AJdfLmSdOmXm7nvj+UvbfyPYAr485lOlJj6AbQ39F1zzIUv
zHIdp6wVKzVI+P4YX0PtiOZybMSPqbry+JlqjMdUnonJ79DG6U4LwuBARdI+tQgu
McqEdo996y+jjMtpSVYmsxxySFXbE3Gx+ZRC5KGJ5doHMsL7W5+4xvEwMt88gXyB
krsCqjdSDevqbMYB04pTUheoBoJ60ArV/Lk2uLhmihchNQdGTV9XXlvxWjfEoZrI
68vTumxNi3tbALGEB9/7jPGsMfMAfMOYEZZBeE6T6WPxKqKCXwxlK3AP0+/yqLFX
crTJdPpZjBrOq/n4234P
=65T9
-----END PGP SIGNATURE-----
--=-=-=--