From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Austin Clements <amdragon@MIT.EDU>,
	Mark Walters <markwalters1009@gmail.com>
Subject: Re: [PATCH v2] emacs: show: lazy part bugfix
In-Reply-To: <20130904145639.GB1426@mit.edu>
References: <1377246875-7784-1-git-send-email-markwalters1009@gmail.com>
	<1378279835-28288-1-git-send-email-markwalters1009@gmail.com>
	<20130904145639.GB1426@mit.edu>
User-Agent: Notmuch/0.16+40~g62789b1 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 04 Sep 2013 08:50:39 -0700
Message-ID: <87hae07fhs.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 04 2013, Austin Clements <amdragon@MIT.EDU> wrote:
>> Now, some mime parts have subparts and to avoid overwriting the
>> sub-part data notmuch checks and if part data is already recorded it
>> does not overwrite it.
>>=20
>> Now with lazy part handling this could fail: there is already part
>> data stored. In the common case it works as the part type information
>> was stored when the lazy-part button was inserted. However, this fails
>> if the lazy part has sub-parts: notmuch had no idea these existed
>> until the lazy part insertion.
>
> This says that things fail when a lazy part has sub-parts, but not
> what the failure is.  What is the failure?  Can you give a specific
> sequence of events and conditions that leads to and demonstrates the
> failure?
>
> (I ask not just for commit posterity, but because I actually don't
> know, though I may have figured it out after writing the comment
> below.)

Hey, Austin.  Here's an example of a mail that is effected the issue:

=E2=94=94=E2=94=AC=E2=95=B4multipart/alternative 896783 bytes
 =E2=94=9C=E2=94=80=E2=95=B4text/plain 379 bytes
 =E2=94=94=E2=94=AC=E2=95=B4multipart/related 892556 bytes
  =E2=94=9C=E2=94=80=E2=95=B4text/html 1236 bytes
  =E2=94=94=E2=94=80=E2=95=B4image/jpeg inline [photo.JPG] 890841 bytes

The multipart/related part is initially hidden.  Without Istvan's patch,
there would be no button at all for the image/jpeg part, even when the
multipart/related is exposed.  With Istvan's patch the image/jpeg button
is there, but without Mark's patch the button would actually reference
the entire multipart/alternative part, instead of just the image/jpeg.
If I tried to save the image/jpeg I would get the entire
multipart/alternative mime structure in plain text.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iQIcBAEBCAAGBQJSJ1bQAAoJEO00zqvie6q8DRQQALfbe4fmzvB+HZYcet9h0kNX
oqdnEH2ePCDl61BdRc22IvbeQK3IyGmzn6ICI57p5crgEQUOJtmY4Bw3zE2UWIIn
cxlY5OXfnY2nojlNE1x58WbufXsxcJ8xlxzhnjJvX6F13jYv+0puXlH1pOwglqWi
c+FMonWdTJSGvL6PxZJum+uVQI/8Z6GMZ+jeIDRDyw/R5JRfqFyYsEnx3YQub340
w7KKzG7kHhYz3BFWcVj1aJ3zGKNYAzLHn7rPIU+3snmGTHdWkp433RakBZdF5Qfy
z0Zwk6EkSPQSFsPpqBus7vKZ1MKgA6qHg+Kals6a3X5nsMmFVxPfdukkGMMU7Oj3
KNIZyi1HoHKWkTtkx3xlCbj0slcX+/ViS0SK9N5wNEsgTR3iXJjc8zOcTksqn2db
aSc6cBAYLhybNGrSKHJmWBu2EJmh02alwEbvgbIyPTV7lD5gK1j3TjBNy674Mp9U
EIQ9U6LtzOyErtvIVpLxO8p6Ai6ieVDv9IUCGEbKAbPUH2Ml8666MrIn7tmRWeuE
IwG0CMySDTQq9Wrou5fhyGdPpWyYk70wVhmOcl3W0oopoKVm5Remnb3G340eBSDe
PMkzet743gzcw78R8/18s1gkvM4DE2exvQOaCVYqIOJRNIH0UyJ3zomJKlcE6UeP
JA2Y46V+tlY4jiHMKjil
=C6rI
-----END PGP SIGNATURE-----
--=-=-=--