From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/2] notmuch hooks
In-Reply-To: <cover.1323176771.git.jani@nikula.org>
References:
 <7fbe6befcf31881a9bca672f55b93501249a220c.1322859389.git.jani@nikula.org>
	<cover.1323176771.git.jani@nikula.org>
User-Agent: Notmuch/0.10~rc1+25~g719d650 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 06 Dec 2011 18:27:27 -0800
Message-ID: <87hb1dru9c.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Tue,  6 Dec 2011 15:22:36 +0200, Jani Nikula <jani@nikula.org> wrote:
> Hi all, this is v3 of the notmuch hooks patches. I think this is nearing
> completion apart from final review and, most notably, tests.

Hey, Jani.  Thanks so much for these patches.  I think this is a really
neat idea and it will be very useful.  I already know that this will cut
out a lot of extraneous shell scripting that I'm relying on now.

> I've been using this for some days now, and (subjective as it is) I have to say
> I like offlineimap being run from notmuch new "pre-new" hook much better than
> vice versa. Even more so for "post-new" tagging scripts.

I think the only thing that I was not particularly clear about is that I
guess the "pre-new" and "post-new" scripts actually need to be scripts
named "pre-new" and "post-new" in the hooks directory.  For some reason
I didn't quite grok that from the help pages, and was confused if I
needed to make a new "pre-new" subdirectory in the hooks directory or
what.  I think just expecting a script at hook/pre-new is fine, but it
maybe could be made a little more explicit in the documentation.

In fact, I think the best thing would actually be for notmuch new to
make the .notmuch/hooks directory itself and to pre-fill it with "turned
off" hook scripts that contain some useful comments on how to use them.
This is what git does, and I think it's very handy, since it's all
fairly self documenting.  The notmuch help could then just refer to the
fact that they're there, and point people to the comments in the various
scripts for how to use them.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJO3s8PAAoJEO00zqvie6q8z9kP/24dNbVzceYCZlBluZXfGh3Q
wLwzf3T6nElrzhXHeBP1iWth361O92rmpsWn9wzRAPN056ph0QBMTp2c1d6grUOR
L4dq91aUHAj0CapvNwcDBsLlnEWeYd3cajYSsPPFqqrjXC+hOmgFFIAGmqjN1oKA
mxCXe82Eq4PxIdVt/Xg5ypYgIJD/VAwK/C0BgNYDBw/lqBIpFeJVOs9hXPCOx27D
Cs0Tl3+gYxRvCWVLxEm2Ite92HGyexYlf9neOcK1hATZQlujgRplneb9tNjCNV9t
v8DtQq8ndY/6votyapwo6roIohkhmfuRZDn32t8NHFzpZwL5zN0p625jY2a5TV3x
Va///jOU3RCuFbAyhNvhKE0+BW7aqi56Y+BitbNoz9F9ZJMg2Fk5eMhfszw4b6to
jkvC9hIy8hsAlVwp5djejmnRXDFoYqdjisG7NdlbOTYbYNsxnEJEjl2yYkQ0hBMP
6n98XGK8I5XD4ymTp52/clYHLP1drwb6/gozP/ltz7PJJuJC4l9YNSVzD+B6JKCs
qQ1IFZlEolKX84iDYhJ9FvdWdRsH0pMSnVs6eYUtFEuxbIVZ0643Q56pPWdW+VfZ
y5IIYFccNjNL8stiOHCxWKF4Rv05yHDPS3rk2RueiO0Dn/EsDuLnDKOGbnuW+ghT
tDqMcGnxvVXZu9WCoHk6
=no9q
-----END PGP SIGNATURE-----
--=-=-=--