Date: Mon, 3 Dec 2012 10:20:15 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Subject: Re: [PATCH] emacs: stash bugfix
Message-ID: <20121203152015.GD1020@mit.edu>
References: <1354443068-5030-1-git-send-email-markwalters1009@gmail.com>
	<20121203013402.GC1020@mit.edu> <87ehj71o4i.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ehj71o4i.fsf@qmul.ac.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth Mark Walters on Dec 03 at  9:27 am:
> 
> On Mon, 03 Dec 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> > Quoth Mark Walters on Dec 02 at 10:11 am:
> >> Currently an attempt to stash a non-existent field (eg cc when not
> >> present) throws an error. Catch this case and give the user a warning
> >> message.
> >> 
> >> ---
> >> While messing around with notmuch-pick key bindings I found the
> >> following bug. The easiest way I have found to trigger it is cc
> >> (stash-cc) in show mode on a message with no cc header.
> >> 
> >> Best wishes
> >> 
> >> Mark
> >> 
> >>  emacs/notmuch-lib.el |    7 +++++--
> >>  1 files changed, 5 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> >> index 1d0ec17..c7d8e02 100644
> >> --- a/emacs/notmuch-lib.el
> >> +++ b/emacs/notmuch-lib.el
> >> @@ -183,8 +183,11 @@ user-friendly queries."
> >>  
> >>  (defun notmuch-common-do-stash (text)
> >>    "Common function to stash text in kill ring, and display in minibuffer."
> >> -  (kill-new text)
> >> -  (message "Stashed: %s" text))
> >> +  (if text
> >> +      (progn
> >> +	(kill-new text)
> >> +	(message "Stashed: %s" text))
> >> +    (message "Warning: Nothing to stash!")))
> >
> > Without the unnecessary "Warning:" bit of the message, LGTM.
> 
> I am obviously happy to remove the "warning": however do you think
> stashing a non-existent thing should empty the kill-ring? I am a little
> worried about someone stashing something, not noticing the "nothing to
> stash" and then pasting some random thing somewhere (eg something
> private into irc).

Mm, interesting.  I don't think you want to empty the kill-ring
because there may be useful things earlier in it.  You could clear out
the window system selection directly, but that's probably flaky and
doesn't help if you're copying around within Emacs.  What about
(kill-new "")?  Then the function would always put something on the
kill-ring (and clipboard/selection/whatever) but it would be harmless
if there was nothing to stash.