Return-Path: <cworth@cworth.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 9C7BF418C36
	for <notmuch@notmuchmail.org>; Tue, 20 Apr 2010 09:25:37 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.89
X-Spam-Level: 
X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
	tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
	autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id rh+A065g3-E2; Tue, 20 Apr 2010 09:25:36 -0700 (PDT)
Received: from yoom.home.cworth.org (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id D4B42418C34;
	Tue, 20 Apr 2010 09:25:36 -0700 (PDT)
Received: by yoom.home.cworth.org (Postfix, from userid 1000)
	id 8923725400A; Tue, 20 Apr 2010 09:25:36 -0700 (PDT)
From: Carl Worth <cworth@cworth.org>
To: David Edmondson <dme@dme.org>, notmuch <notmuch@notmuchmail.org>
Subject: Re: pull request
In-Reply-To: <8739yq8zix.fsf@ut.hh.sledj.net>
References: <87sk722sfq.fsf@ut.hh.sledj.net> <87eiibq22s.fsf@ut.hh.sledj.net>
	<87ljcj2u4z.fsf@yoom.home.cworth.org>
	<8739yq8zix.fsf@ut.hh.sledj.net>
Date: Tue, 20 Apr 2010 09:25:36 -0700
Message-ID: <877ho2w0ov.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2010 16:25:37 -0000

--=-=-=

On Tue, 20 Apr 2010 06:27:02 +0100, David Edmondson <dme@dme.org> wrote:
> The second chunk was intended to cover a similar case (len == 0), but
> becomes unnecessary after the first chunk. At least, that's what I
> convinced myself after the conversation with Anthony Towns
> (id:h2y87b3a4191004060117v5421db8ejbe3030d0626e7440@mail.gmail.com).

Thanks for the clarification.

And I really appreciated seeing a reference to the original discussion
that led to this patch. You'll notice there that Anthony's proposed
commit had the same patch content that you had in your tree, but with a
more detailed commit message, ("and always return a newly talloced
array").

That was exactly the kind of explanation I was looking for but couldn't
find in the commit I first reviewed. It wasn't really a question of
whether the code was correct. The problem was that there was a code
change that wasn't described in the commit message. I don't want that
even if the change is correct.

Anyway, thanks AJ and David.

I've now pushed my version of these changes up through this point. I'm
currently working on the make-emacs-use-JSON patch, (it's got some
confusion about "body visible" vs. "message visible" that I want to fix
before pushing).

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLzdWA6JDdNq8qSWgRAsHXAJoCbykIYcx3hPiytv+1HbgD+sBcoQCePU52
9i6ngmNfd/RBD93tHrFYk/8=
=dgoA
-----END PGP SIGNATURE-----
--=-=-=--