Date: Sun, 6 Dec 2009 18:34:37 +0100
From: Ruben Pollan <meskio@sindominio.net>
To: Carl Worth <cworth@cworth.org>
Message-ID: <20091206173437.GD5109@blackspot>
References: <20091126202347.GA16654@blackspot>
	<87pr73jo6w.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="iVCmgExH7+hIHJ1A"
Content-Disposition: inline
In-Reply-To: <87pr73jo6w.fsf@yoom.home.cworth.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: notmuch@notmuchmail.org
Subject: Re: [notmuch] notmuch_threads_back and notmuch_messages_back
Precedence: list


--iVCmgExH7+hIHJ1A
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 19:57, Fri 27 Nov 09, Carl Worth wrote:
> (I'd like a verb that pairs better
> with "advance" than the non-verb "back"---any suggestions)?

What about regress?
I'm not a native English speaker, so maybe someone can suggest something be=
tter.

> So those won't need any new code. The one case that will need new code
> is that for notmuch_message_get_replies and
> notmuch_message_get_toplevel_messages the messages iterator is currently
> built on a singly-linked list. Making it doubly linked would obviously
> not be hard though.

I'm trying to convert it to a doubly linked list, but I'm not sure if I
understand well how they work.

I don't see how _notmuch_message_list_append works. It says "node can of co=
urse
point to an arbitrarily long list of nodes", but the code is:

void
_notmuch_message_list_append (notmuch_message_list_t *list,               =
=20
                  notmuch_message_node_t *node)                           =
=20
{  =20
    *(list->tail) =3D node;
    list->tail =3D &node->next;
}

Should not be something like:

void
_notmuch_message_list_append (notmuch_message_list_t *list,               =
=20
                  notmuch_message_node_t *node)                           =
=20
{  =20
    notmuch_message_node_t *next_node;

    *(list->tail) =3D node;
	for (next_node =3D node->next; next_node->next !=3D NULL;
	     next_node =3D next_node->next);
	list->tail =3D &next_node->next;
}

Do I miss something? Or the function is just designed to work on a single n=
ode
not a list of them?


--=20
Rub=E9n Poll=E1n  | jabber:meskio@jabber.org
-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=
=3D-=3D-=3D-=3D-=3D-
         No vamos a reivindicar nada,
            no vamos a pedir nada.
            Tomaremos, okuparemos.

--iVCmgExH7+hIHJ1A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAksb6y0ACgkQGKOQ92SwNMKMgwCZAWxxhi/Q7JmGP9Ei8jNdn+tf
OVoAmQE3utGJsdC8wH3KkkmpFPfZD/Ue
=Rfin
-----END PGP SIGNATURE-----

--iVCmgExH7+hIHJ1A--