Date: Sun, 22 Jan 2012 23:34:35 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Pieter Praet <pieter@praet.org>
Subject: Re: [PATCH v2 5/6] setup: prompt user for search.exclude_tags value
Message-ID: <20120123043435.GR16740@mit.edu>
References: <87obtvaw8h.fsf@praet.org>
	<1327292557-7701-5-git-send-email-pieter@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1327292557-7701-5-git-send-email-pieter@praet.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

Quoth Pieter Praet on Jan 23 at  5:22 am:
> Allow users to customize the search.exclude_tags option during setup.
> ---
>  notmuch-setup.c |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/notmuch-setup.c b/notmuch-setup.c
> index dcfa607..0d75adc 100644
> --- a/notmuch-setup.c
> +++ b/notmuch-setup.c
> @@ -133,6 +133,8 @@ notmuch_setup_command (unused (void *ctx),
>      int is_new;
>      const char **new_tags;
>      size_t new_tags_len;
> +    const char **search_exclude_tags;
> +    size_t search_exclude_tags_len;
>  
>  #define prompt(format, ...)					\
>      do {							\
> @@ -208,6 +210,25 @@ notmuch_setup_command (unused (void *ctx),
>  	g_ptr_array_free (tags, TRUE);
>      }
>  
> +
> +    search_exclude_tags = notmuch_config_get_search_exclude_tags (config, &search_exclude_tags_len);
> +
> +    printf ("Tags to exclude when searching messages (separated by spaces) [");
> +    print_tag_list(search_exclude_tags, search_exclude_tags_len);

Missing space before paren.

> +    prompt ("]: ");
> +
> +    if (strlen (response)) {
> +	GPtrArray *tags = parse_tag_list (ctx, response);
> +
> +	notmuch_config_set_search_exclude_tags (config,
> +						(const char **)
> +						tags->pdata,

No newline is needed between the case and the value.

> +						tags->len);
> +
> +	g_ptr_array_free (tags, TRUE);
> +    }
> +
> +
>      if (! notmuch_config_save (config)) {
>  	if (is_new)
>  	  welcome_message_post_setup ();