Date: Sat, 29 Nov 2014 12:18:29 -0800
From: "W. Trevor King" <wking@tremily.us>
To: Michal Sojka <sojkam1@fel.cvut.cz>
Subject: Re: [PATCH v3] nmbug: Add an 'init' command
Message-ID: <20141129201829.GI4062@odin.tremily.us>
References:
 <113512958b3fd64902517c1c55576faef816f852.1414532174.git.wking@tremily.us>
	<87a93a5or2.fsf@resox.2x.cz>	<20141129200917.GH4062@odin.tremily.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="l0l+eSofNeLXHSnY"
Content-Disposition: inline
In-Reply-To: <20141129200917.GH4062@odin.tremily.us>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--l0l+eSofNeLXHSnY
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 29, 2014 at 12:09:17PM -0800, W. Trevor King wrote:
> On Sat, Nov 29, 2014 at 10:40:01AM +0100, Michal Sojka wrote:
> > On =C3=9At, =C5=99=C3=ADj 28 2014, W. Trevor King wrote:
> > > +        _spawn(
> > > +            args=3D['git', 'init', '--separate-git-dir', NMBGIT, wor=
kdir],
> > > +            wait=3DTrue)
> > > +        _git(args=3D['config', '--unset', 'core.worktree'], wait=3DT=
rue)
> > > +        _git(args=3D['config', 'core.bare', 'true'], wait=3DTrue)
> >=20
> > Why do you create a non-bare repository and then make it bare?
>=20
> Bare repositories don't usually have upstream tracking branches.  See
> the commit message for c2001674 (nmbug: Add 'clone' and replace
> FETCH_HEAD with @{upstream}, 2014-03-09) for details [1].  I can
> resubmit this patch with a commit message that mentions the
> explanation in c2001674 if folks want the extra clarity here.

Ah, it seems that the lack of remote-tracking branches is unique to
'clone --bare'.  When I compare 'init --bare' with the above (using
Git 2.1.0), the only difference in the resulting repository is that
the the 'init --bare' form doesn't set core.logallrefupdates, while
the form above sets core.logallrefupdates to true.  I'll submit v4
using 'init --bare' and an explicit core.logallrefupdates config.

Cheers,
Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--l0l+eSofNeLXHSnY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUeioUAAoJEG8/JgBt8ol8O44P/ig2SMSU0ecNZ2xwuE6Fp4Vv
pfjT5qcIx5YVK8NySY7jXPTB9Vg3rgkx/Khb8M0ZUWdSu+YJKVID1hBpL51bTe32
eCtLYwtutf8c8Nw6urJvas+noqTGCZsLQbuBAt54hBgya8waVWqqy7VVMGaonIaK
abvqkuXQn2Z6050ZCfSWT5xfBYGxiEOxfpdHrwPuWUo52rws2/FkusspyjNaFX6z
fT79zOw9Jd8h211JoaGYc6LueuhM4xN8AU8xdhp6SQxTRV0pZzy6SqAaknhSRAwM
0hg0dAGCBoSDQMh0jC0CB3I/8ARnVVWfNjvDWkYCLB0kHF5rp6LDUj157QRaDF5l
3o/kBYZiGm+2yvJeD/oP7cKQCoKWNocqCtrteuFNqe9j8Vgx8ivgYEh/X8WGLGQt
rbFaqOICv+diNPaDsdCuvfHP1oElgOoLuvEY2xUIA2PxrQdPlpsHtvAzGEauuU+/
wOFgjahEWnFIcMII93uP9ByZjJ1y7a50rPdcO3j6bfrLomVRkrDgZYgQmRhzHBCt
F8EyYQEDSV511Pd3KDxXpM4viLUw/OcK+v6kz+93CWH57cq5B00ZMNGoeYdU8HhP
frMasnU/ovtavKtmSOxGCZpLcAFTm6xH2lAIqCL9qU7Qw/xfmmWBoXD50Zj9cS/7
0bI5CJSrgOKJJBjr6Ue8
=bnI1
-----END PGP SIGNATURE-----

--l0l+eSofNeLXHSnY--