From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t
In-Reply-To: <87mwzi6tr6.fsf@betacantrips.com>
References: <1340198947-29370-1-git-send-email-novalazy@gmail.com>
	<1340198947-29370-8-git-send-email-novalazy@gmail.com>
	<87txtr6o0c.fsf@betacantrips.com> <87mwzi6tr6.fsf@betacantrips.com>
User-Agent: Notmuch/0.14+51~g62cd13b (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
Date: Sat, 20 Oct 2012 13:04:23 +0300
Message-ID: <m28vb1a28o.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Sat, Oct 20 2012, Ethan Glasser-Camp wrote:

> Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> writes:
>
>> It looks like you have better wording for patch 4/8 so I'd like to see
>> you resend it.
>>
>> I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit!
>
> It turns out that patch 4 already has a v2 in the thread, but I didn't
> see it due to some kind of selective blindness. It would be nice if
> nmbug had grouped it as part of the same patch series. 

I noticed the same today when I tagged your NEWS patch.

By looking contrib/nmbug/nmbug-status the reason seems obvious:
it iterates over messages and resets thread when thread id changes
(and message ordering is not based on threads).

There is 2 ways to "fix" this: 

1) Iterate over threads and then messges over these threads. I looked
the bindings and this didn't seem so easy as one could imagine..

2) Iterate over messages like now, but cache the content to an objects
in hash where thread-id is the key.
 
If no-one points me an easy way to do (1), I'll attempt (2) (in a distant
future ;)

>
> I'm marking the old patch 4/8 obsolete. Only patch 3 and 7 remain.
>
> Ethan

Tomi