Return-Path: <dmitry.kurochkin@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id C1000431FAE
	for <notmuch@notmuchmail.org>; Fri,  3 Feb 2012 06:05:25 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.799
X-Spam-Level: 
X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id dBW5B87m7kxO for <notmuch@notmuchmail.org>;
	Fri,  3 Feb 2012 06:05:23 -0800 (PST)
Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
	[209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 9A589431FAF
	for <notmuch@notmuchmail.org>; Fri,  3 Feb 2012 06:05:23 -0800 (PST)
Received: by bke11 with SMTP id 11so3500552bke.26
	for <notmuch@notmuchmail.org>; Fri, 03 Feb 2012 06:05:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:in-reply-to:references:user-agent:date:message-id
	:mime-version:content-type;
	bh=15mfm5zWa44TnheeMmLKqOdZePwlX7QAHMuo7QWOa+I=;
	b=vNEjWJQQXBcuIRLnIHhELwX/Hv7njQ0WYkIZmlu8Ph+pG1Jn4O/oOdvU/qzIF45WG3
	PvxSX4A7QOPgfQftN9oV1r7jtxJbdFgvu87SF1C54Wmt1DezheG5gCJkgtH7GdMW81sD
	sBzGoU2wOIhmewZE7UadFnHsNWvyENgH2r1vw=
Received: by 10.204.154.28 with SMTP id m28mr3517503bkw.54.1328277920819;
	Fri, 03 Feb 2012 06:05:20 -0800 (PST)
Received: from localhost ([91.144.186.21])
	by mx.google.com with ESMTPS id e17sm13905643bkz.13.2012.02.03.06.05.19
	(version=TLSv1/SSLv3 cipher=OTHER);
	Fri, 03 Feb 2012 06:05:19 -0800 (PST)
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for
	test_expect_equal_file
In-Reply-To: <87zkd1p12c.fsf@servo.finestructure.net>
References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>
	<87zkd1p12c.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 03 Feb 2012 18:04:05 +0400
Message-ID: <87sjishv3e.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Feb 2012 14:05:26 -0000

On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> Hey, Dmitry.  I'm so sorry I sent my last email on your original patch
> before I saw this new series.  I do now like your original proposal
> better, since it shows the diff based the names the caller provides,
> which I now agree is probably the clearest and most robust solution.
> The second patch in this series could still go through, though, no
> matter what version of the change to test_expect_equal_file we go with.
> 

Actually, we can do both: check file name for consistent diff order
(from expected to actual) and use file names that the caller provides.

What do you think?

Regards,
  Dmitry

> jamie.