From: Mark Walters <markwalters1009@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)
In-Reply-To: <87bon47v0o.fsf@servo.finestructure.net>
References: <1333716551-29153-1-git-send-email-markwalters1009@gmail.com>
	<87bon47v0o.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.12+96~g8f5ec3b (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 06 Apr 2012 16:38:20 +0100
Message-ID: <87ty0w50r7.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Fri, 06 Apr 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Fri, Apr 06 2012, Mark Walters <markwalters1009@gmail.com> wrote:
>> This is the latest version of the patch series (previous version at [1]).
>> I think this version fixes all the problems raised by Austin in his review.
>
> Tested and reviewed and LGTM.
>
> Unfortunately, though, I just now noticed that the tests don't cover
> count and show excludes.  Since everything else looks good, let's just
> make a new version of [0].  I suggest we name the new test script just
> "excludes" and then add count and show tests there.  That should be
> pretty straightforward.

There are some exclude tests for count in test/count. Do you think it
needs to be a full test everything like in test/search-exclude?

There aren't any tests for show exclude, but there aren't very many
tests explicitly for show anyway. My preference would be to add
something like
id:"1332171061-27983-1-git-send-email-markwalters1009@gmail.com" and add
some tests to that. I could add some tests for show-excludes in the same format
as the search-exclude tests though if you think that is better.

Best wishes

Mark
>
> Thanks again, Mark.
>
> jamie.
>
> [0] id:"1333716551-29153-5-git-send-email-markwalters1009@gmail.com"