Return-Path: <jrollins@finestructure.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id A6380431FBF
	for <notmuch@notmuchmail.org>; Sun, 15 Jul 2012 14:14:50 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.29
X-Spam-Level: 
X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id hFov3JDKzCAU for <notmuch@notmuchmail.org>;
	Sun, 15 Jul 2012 14:14:50 -0700 (PDT)
Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
	[131.215.239.19])
	by olra.theworths.org (Postfix) with ESMTP id 1B900431FBC
	for <notmuch@notmuchmail.org>; Sun, 15 Jul 2012 14:14:50 -0700 (PDT)
Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])
	by fire-doxen-postvirus (Postfix) with ESMTP id 9B3D32E50BAA;
	Sun, 15 Jul 2012 14:14:47 -0700 (PDT)
X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new
Received: from finestructure.net (rrcs-24-199-56-74.west.biz.rr.com
	[24.199.56.74]) (Authenticated sender: jrollins)
	by fire-doxen-submit (Postfix) with ESMTP id C982F2E50485;
	Sun, 15 Jul 2012 14:14:43 -0700 (PDT)
Received: by finestructure.net (Postfix, from userid 1000)
	id 746F6688; Sun, 15 Jul 2012 14:14:42 -0700 (PDT)
From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>,
	Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/8] emacs: JSON-based search cleanups
In-Reply-To: <87fw8ttob9.fsf@qmul.ac.uk>
References: <1342140319-19859-1-git-send-email-amdragon@mit.edu>
	<1342306940-7499-1-git-send-email-amdragon@mit.edu>
	<87fw8ttob9.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.13.2+89~g9ab91ad (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Sun, 15 Jul 2012 14:14:40 -0700
Message-ID: <87a9z0zpz3.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jul 2012 21:14:50 -0000

--=-=-=

On Sun, Jul 15 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> However, there are some problems with multiline search results (see
> below) so I think we should either fix these or just downplay this new
> functionality by, for example, removing the comments on newlines from
> the defcustom and saying in NEWS that the feature is experimental/not
> complete or similar. (NEWS could say how to enter newlines in the
> defcustom)
>
> With this minor comment on the documentation my criticisms should not
> hold up this excellent series.

I agree that multi-line support needs a little bit more work before it's
ready for prime time.  I'll keep experimenting with it as well and see
if I can uncover any other issues.

But I definitely also agree that that work should *not* hold up this
patch series, as it adds plenty of other benefits.

> Examples of "incompleteness": these are rather more personal but it
> seems odd to me to highlight one line rather than one result in the
> buffer. Similarly I would expect <up> <down> to scroll up or down by
> one result rather than one line.

Highlighting the entire entry should definitely be fixed, since
otherwise it can be hard to see which of the other lines is associated
with the current entry.

I also notice that the author field munging causes some weird behaviors.
Certain formatter strings can cause it to break.  If we can get that
fixed it might be nice to have a similar functionality for the subject
field, which can also be really long.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQAzLAAAoJEO00zqvie6q8DPcP/2jLHR37CHVl0n8FUlvw1I+0
ASrtz2PnytHP5LtEWFFYCdY3lCeCdI728SbcX0cqr9eb+zFyUW/F07RZ01/exCn3
2QC+lUwHT7F4WlCqNTnvG1zAPgHcTmi+twZKibo/u8U20wDxBh+UO78My/dVUQoa
TYesodWSVOrPnMptXc12V7fS/lk6t4G6hLK3qGvH4hWtrk3eUzcGXt3kKiSioQio
hBBdNnQPa64jXy/kUS7y+wFWnb4N5Zsgg/pRgdtF1LEG8ECXifHRHt3OFdTKihd+
x5V0CeqxmQFsXtHaqpEgQTaTl6EQaYvfvGdk0Lwhqk1Rd+rtKZhtU6JSy+3PhZ+N
lfNibIRBwhVoT9ZSWjaniYzooJ0IMDLmISLB8NmmsO59br2Lw+98Tz53JFCHXCHY
L7+hL23/AgqjRFTBGuw1gt32rcn+W1mQ+oMqYGGRd4nG0wruiu+eOFTu+dzKqLCa
YsVeKWVIXfnIUftr2uHf9NLSd3nsa8E97EgVoOGGC7kOOJvYB7oXatpYZtuFxWcg
4JL7vsJLVi9/nXBOqijYi9qbRgGbBOihEoKqqbfSVe6W/l9aXV4B+gM51zqibh7l
W2ofo8E4gbYPHHaKvjnnGfsVh2XRNRWA4+eqF8HR7XkEcTd3xO/7cinkAbj0n7Hi
mxMO9vxS2vYP7AKpJy1C
=EQ+5
-----END PGP SIGNATURE-----
--=-=-=--