Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E8E04431FAE for ; Sat, 4 Aug 2012 00:04:57 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p3JKWFfQ0Xxr for ; Sat, 4 Aug 2012 00:04:56 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id D7CEE431FAF for ; Sat, 4 Aug 2012 00:04:55 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id 69D6B100372; Sat, 4 Aug 2012 10:05:04 +0300 (EEST) From: Tomi Ollila To: Austin Clements Subject: Re: [PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait In-Reply-To: <20120803205216.GG22601@mit.edu> References: <1343996163-26720-1-git-send-email-tomi.ollila@iki.fi> <20120803205216.GG22601@mit.edu> User-Agent: Notmuch/0.13.2+123~gd19b5be (http://notmuchmail.org) Emacs/23.1.1 (x86_64-redhat-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2012 07:04:58 -0000 On Fri, Aug 03 2012, Austin Clements wrote: > Code LGTM, but maybe the comment should explain that this is a > workaround for a bug in Emacs, given that both sleep-for and sit-for > are supposed to process process output and run sentinels (which has > been stated in the Elisp reference at least as far back as Emacs 21). > In light of this (and our better understanding of sleep-for and > sit-for from IRC discussions), the commit message is also misleading. Indeed... Tomi