DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:cc:subject:in-reply-to:references:user-agent:date
	:message-id:mime-version:content-type;
	b=QLwjx2TZVoAIqH3UOdu+JuTS8Cd43fGBI7ss5QsymWBNK/9x2HGoSaD8atKFxl62+F
	nL5usuH9F1L8w9b/yA4aEeTLXH3adsjczBOKH//ZZ5uhOh8XhiHoXTDQzNPmh2JdvUV8
	bGPOTFGtNAbmp5rZXjn5RNoxTrBLTSpH3iB8U=
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Carl Worth <cworth@cworth.org>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.
In-Reply-To: <87hb7gdw7d.fsf@yoom.home.cworth.org>
References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-2-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-3-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-4-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-5-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-6-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-7-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-8-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-9-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-10-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-11-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-12-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-13-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-14-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-15-git-send-email-jrollins@finestructure.net>
	<874o48yg28.fsf@yoom.home.c worth.org> <87lixkpw16.fsf@gmail.com>
	<87oc2ellzn.fsf@yoom.home.cworth.org> <87ipsmpswj.fsf@gmail.com>
	<87hb7gdw7d.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5-260-g027d4ad (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 24 Jun 2011 02:58:23 +0400
Message-ID: <87hb7g17g0.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Bremner <bremner@debian.org>
Precedence: list

On Thu, 23 Jun 2011 15:22:46 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Sat, 04 Jun 2011 00:22:04 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > On Fri, 03 Jun 2011 13:05:00 -0700, Carl Worth <cworth@cworth.org> wrote:
> > > > I do not think we need a test for this fix.  What we need are tests for
> > > > FCC functionality when notmuch-fcc-dirs is a list.
> > > 
> > > Yes!
> 
> I've written these now. And they do test this fix. What they show is
> that a legitimate setting (of notmuch-fcc-dirs as a list) was resulting
> in an error rather than working. That's a nasty little bug, (and poor
> coverage from our test suite before.
> 
> >   Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup' when
> >   `notmuch-fcc-dirs' is set to a list.  The error was in the
> >   `notmuch-fcc-dirs' format check which was changed in an incompatible
> >   way from 0.4 to 0.5.
> 
> Thanks for the fixed wording. I've now pushed out the fix (along with
> the tests).
> 
> With all the talk of "old style" vs. "new style" I was thinking that the
> bug only affected people with the old-style FCC setting. The bug is much
> worse than that, (preventing people from using the new list-based
> style).
> 
> Anyway, thanks for the patch, Dmitry. And thanks for pushing me to take
> another look.
> 

Well, I should have prepared a better commit message from the
beginning.  Then no pushing might have been needed :)

Regards,
  Dmitry

> David, I suggest including this fix (and its test) in the release
> branch.
> 
> -Carl
> 
> -- 
> carl.d.worth@intel.com