To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/4 v2] test: Add test for Original Message hiding at
	point-min.
In-Reply-To: <87liovhdob.fsf@gmail.com>
References: <1327503908-17226-1-git-send-email-dme@dme.org>
	<1327506328-22126-1-git-send-email-dme@dme.org>
	<1327506328-22126-4-git-send-email-dme@dme.org>
	<87liovhdob.fsf@gmail.com>
User-Agent: Notmuch/0.11+114~g550724b (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Thu, 26 Jan 2012 07:22:07 +0000
Message-ID: <cunty3jkjxc.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

I've applied changes in accordance with all of the feedback in this mail
and the others, except for...

On Wed, 25 Jan 2012 21:53:08 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> > +  (let ((notmuch-show-insert-text/plain-hook '(notmuch-wash-excerpt-ci=
tations))
>=20
> Do we have to override the default value here?  I thought
> notmuch-wash-excerpt-citations was enabled by default.

It avoids potential confusion over where the problem lies.

> [...]
>=20
> IMO writing the test in lisp does not give any benefit in this case.
> Quite the opposite: a simple test is split in two files and becomes more
> complex.
>=20
> But since we accepted this way of writing tests and you seem to prefer
> it, I would not argue about changing it.

You're right - it's simpler in the original style here, so v3 switches
to that.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8g/x8ACgkQaezQq/BJZRZ7kgCfafkhNjUuQwzFyZgjLuDdr1ym
FVMAn1IvC+lhLOBo8Vh9Lix98svO9TFZ
=y6wt
-----END PGP SIGNATURE-----
--=-=-=--