Date: Wed, 28 Mar 2012 22:08:31 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Subject: Re: [PATCH] emacs: Fix mis-named argument to
	notmuch-get-bodypart-internal
Message-ID: <20120329020831.GZ2670@mit.edu>
References: <1332812426-26684-1-git-send-email-amdragon@mit.edu>
	<87ty18kwmd.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ty18kwmd.fsf@servo.finestructure.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth Jameson Graef Rollins on Mar 28 at  6:46 pm:
> On Mon, Mar 26 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> > Previously, this function took an argument called "message-id", even
> > though it was a general query, rather than a message ID.  This changes
> > it to "query".
> 
> I'm sure the argument was named such because: the function is retrieving
> a message part so the query has to match just a single message, and it's
> only ever given a message id by anything that calls it.  And it's an
> unexposed internal function.  All of this to say that I think it doesn't
> really matter that the argument was named as it was.

All true.  But there's a difference between a message ID and an id:
query and the argument name threw me off for a moment when I was
writing the id: query quoting patch.  It could be `id-query', I
suppose, but really it could be any query that matches a single
message.