Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 60DE6429E21 for ; Wed, 16 Nov 2011 22:22:01 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BLsdTY27TE+V for ; Wed, 16 Nov 2011 22:22:00 -0800 (PST) Received: from mail-yw0-f53.google.com (mail-yw0-f53.google.com [209.85.213.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 99FB7431FD0 for ; Wed, 16 Nov 2011 22:22:00 -0800 (PST) Received: by ywp18 with SMTP id 18so810549ywp.26 for ; Wed, 16 Nov 2011 22:22:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.185.138 with SMTP id fc10mr39696781igc.33.1321510919987; Wed, 16 Nov 2011 22:21:59 -0800 (PST) Received: by 10.68.58.71 with HTTP; Wed, 16 Nov 2011 22:21:59 -0800 (PST) Received: by 10.68.58.71 with HTTP; Wed, 16 Nov 2011 22:21:59 -0800 (PST) In-Reply-To: <87d3crd9yr.fsf@praet.org> References: <87zkfwn4lm.fsf@zancas.localnet> <1321475870-29674-1-git-send-email-pieter@praet.org> <1321475870-29674-3-git-send-email-pieter@praet.org> <87d3crd9yr.fsf@praet.org> Date: Thu, 17 Nov 2011 08:21:59 +0200 Message-ID: Subject: Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace From: Jani Nikula To: Pieter Praet Content-Type: multipart/alternative; boundary=14dae9341053f3e04904b1e83c00 Cc: Tomi Ollila , Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2011 06:22:01 -0000 --14dae9341053f3e04904b1e83c00 Content-Type: text/plain; charset=UTF-8 On Nov 16, 2011 11:39 PM, "Pieter Praet" wrote: > > On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila wrote: > > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet wrote: > > > No further explanation needed. > > > --- > > > NEWS | 14 +++++++------- > > > 1 files changed, 7 insertions(+), 7 deletions(-) > > > > The 'No further explanation needed.' should be *BELOW* the waistline (---) ;); > > now it goes to the commit message which is probably not what anybody wants. > > > > That was intended :) > > Empty commit messages are frowned upon (even if the commit subject is > sufficiently descriptive), so "rather a pointless one than none?" :) Generally I think the message should be self-contained and understandable without the subject line, so IMHO a full meaningful sentence is better than one/none, even if it's repetition. BR, Jani. --14dae9341053f3e04904b1e83c00 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Nov 16, 2011 11:39 PM, "Pieter Praet" <pieter@praet.org> wrote:
>
> On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet <pieter@praet.org> wrote:
> > > No further explanation needed.
> > > ---
> > > =C2=A0NEWS | =C2=A0 14 +++++++-------
> > > =C2=A01 files changed, 7 insertions(+), 7 deletions(-)
> >
> > The 'No further explanation needed.' should be *BELOW* th= e waistline (---) ;);
> > now it goes to the commit message which is probably not what anyb= ody wants.
> >
>
> That was intended :)
>
> Empty commit messages are frowned upon (even if the commit subject is<= br> > sufficiently descriptive), so "rather a pointless one than none?&= quot; :)

Generally I think the message should be self-contained and understandabl= e without the subject line, so IMHO a full meaningful sentence is better th= an one/none, even if it's repetition.

BR,
Jani.

--14dae9341053f3e04904b1e83c00--