Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E482B4196F2 for ; Wed, 14 Apr 2010 11:04:12 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1iddUZ8TOiw9; Wed, 14 Apr 2010 11:04:12 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3E109431FC1; Wed, 14 Apr 2010 11:04:12 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id ED6BD568DE1; Wed, 14 Apr 2010 11:04:11 -0700 (PDT) From: Carl Worth To: Aaron Ecay , notmuch@notmuchmail.org Subject: Re: [PATCH 4/4] Add CONFIGURE_LDFLAGS to the notmuch-shared buld command line. In-Reply-To: <1271029494-89014-4-git-send-email-aaronecay@gmail.com> References: <4bc25ea0.86c3f10a.45a3.ffff80d3@mx.google.com> <1271029494-89014-4-git-send-email-aaronecay@gmail.com> Date: Wed, 14 Apr 2010 11:04:11 -0700 Message-ID: <87r5mhgbc4.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2010 18:04:13 -0000 --=-=-= On Sun, 11 Apr 2010 19:44:54 -0400, Aaron Ecay wrote: > Otherwise, symbol not found errors result on OS X. I am not sure > this is the correct solution for the problem, but it gets the build > working. ... > -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch > +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch $(CONFIGURE_LDFLAGS) > FINAL_LIBNOTMUCH_LDFLAGS = $(LDFLAGS) $(CONFIGURE_LDFLAGS) As I mentioned earlier in the thread, this isn't the correct solution for Linux. Previously we had just FINAL_LDFLAGS that were used for both the binary and the library. We split this into FINAL_NOTMUCH_LDFLAGS and FINAL_LIBNOTMUCH_LDFLAGS precisely to avoid excess library dependencies on Linux. So the above patch would undo that which is not what we want. -Carl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFLxgOb6JDdNq8qSWgRAuz/AJ9fMosI3hlbUEuFk0r3k1Jtx7dtSgCfSZ00 VOGaM4gcTOkfrYm6T2+bAR0= =BUYw -----END PGP SIGNATURE----- --=-=-=--