From: Carl Worth <cworth@cworth.org>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/5] Git-based modularization of test suite
In-Reply-To: <874odkm4ey.fsf@yoom.home.cworth.org>
References: <1276152484-1164-1-git-send-email-sojkam1@fel.cvut.cz>
	<874odkm4ey.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.3.1-61-g9f0accb (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Mon, 20 Sep 2010 16:46:15 -0700
Message-ID: <871v8om114.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 20 Sep 2010 15:33:09 -0700, Carl Worth <cworth@cworth.org> wrote:
> I think what I'd prefer to have is for test-lib.sh to populate a
> non-empty database (it could even provide a function to reset the
> database to empty for any tests that actually want that).

I've now implemented this. I did it slightly differently, making
test-lib.sh provide an empty database by default and allowing tests to
call a new add_email_corpus function if they need a bunch of email to
work with.

That's because it turns out that many of the existing tests really do
want to focus only on a few, carefully-controlled messages (think about
the tests for "notmuch reply" for example).

> For efficiency, the non-empty database could be created just once at the
> first invocation and then could simply be copied into place for future
> invocations.

I did do it this efficient way. It's only being used currently by the
search and dump-restore tests, so that efficiency doesn't matter too
much yet. But I do expect many more tests to start using this
functionality soon.

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMl/JH6JDdNq8qSWgRAhHEAJ9w+U4pgFTvYRFR/ycH7RJfczt2CACeP2Q0
J44FZwXQ4WEVY66hztmoZYw=
=1ao+
-----END PGP SIGNATURE-----
--=-=-=--