Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 17964431FD0 for ; Sat, 11 Jan 2014 08:05:05 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gFeZJZm07e9w for ; Sat, 11 Jan 2014 08:04:57 -0800 (PST) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4DA5A431FC3 for ; Sat, 11 Jan 2014 08:04:57 -0800 (PST) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1W213N-00048R-Ar; Sat, 11 Jan 2014 12:04:53 -0400 Received: (nullmailer pid 1832 invoked by uid 1000); Sat, 11 Jan 2014 16:04:49 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: test: (gnu) tar(1) portability In-Reply-To: References: User-Agent: Notmuch/0.17+16~gd4acd22 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 11 Jan 2014 12:04:49 -0400 Message-ID: <87ppny7bdq.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jan 2014 16:05:05 -0000 Tomi Ollila writes: > > 2) Change calls to 'tar' to format ${GNU_TAR:-tar} so testers can set > environment variable GNU_TAR to the name/path of gnu tar when running > tests (like GNU_TAR=/usr/local/bin/gtar make test or GNU_TAR=gtar ...) I don't really see any downside to this option; there's only a few calls to tar to replace. Of course we could bikeshed about whether to write TAR=${GNU_TAR:-tar} ... ${TAR} --frub --blah instead of testing GNU_TAR everywhere. But, shrug... d