Date: Mon, 26 Nov 2012 18:21:21 +0200
From: Ali Polatel <polatel@gmail.com>
To: Peter Wang <novalazy@gmail.com>
Subject: Re: [PATCH 04/18] insert: copy stdin to Maildir tmp file
Message-ID: <20121126162121.GA5669@hayalet>
Mail-Followup-To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
References: <1343223767-9812-1-git-send-email-novalazy@gmail.com>
	<1343223767-9812-4-git-send-email-novalazy@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO"
Content-Disposition: inline
In-Reply-To: <1343223767-9812-4-git-send-email-novalazy@gmail.com>
User-Agent: Mutt/1.5.21 (2011-07-01)
Cc: notmuch@notmuchmail.org
Precedence: list


--2oS5YaxWCcQjTEyO
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 25, 2012 at 11:42:33PM +1000, Peter Wang wrote:
>Read the new message from standard input into the Maildir tmp file.
>---
> notmuch-insert.c |   51 +++++++++++++++++++++++++++++++++++++++++++++++++=
--
> 1 files changed, 49 insertions(+), 2 deletions(-)
>
>diff --git a/notmuch-insert.c b/notmuch-insert.c
>index f01a6f2..340f7e4 100644
>--- a/notmuch-insert.c
>+++ b/notmuch-insert.c
>@@ -75,21 +75,68 @@ maildir_open_tmp (void *ctx, const char *dir, char **t=
mppath, char **newpath)
> }
>
> static notmuch_bool_t
>+copy_fd_data (int fdin, int fdout)
>+{
>+    char buf[4096];
>+    char *p;
>+    ssize_t remain;
>+    ssize_t written;
>+
>+    for (;;) {
>+	remain =3D read (fdin, buf, sizeof(buf));
>+	if (remain =3D=3D 0)
>+	    break;
>+	if (remain < 0) {
>+	    if (errno =3D=3D EINTR)
>+		continue;
>+	    fprintf (stderr, "Error: reading from standard input: %s\n",
>+		     strerror (errno));
>+	    return FALSE;
>+	}
>+
>+	p =3D buf;
>+	do {
>+	    written =3D write (fdout, p, remain);
>+	    if (written =3D=3D 0)
>+		return FALSE;
>+	    if (written < 0) {
>+		if (errno =3D=3D EINTR)
>+		    continue;
>+		fprintf (stderr, "Error: writing to temporary file: %s",
>+			 strerror (errno));
>+		return FALSE;
>+	    }
>+	    p +=3D written;
>+	    remain -=3D written;
>+	} while (remain > 0);
>+    }
>+
>+    return TRUE;
>+}

LGTM. As an optimisation we can also consider using the splice(2) system
call if it is available (as notmuch-deliver does). In case splice()
fails with ENOSYS or EINVAL we can fall back to this method.

I can write the patch for it once this is accepted.
Thanks for the good work!

>+static notmuch_bool_t
> insert_message (void *ctx, notmuch_database_t *notmuch, int fdin,
> 		const char *dir)
> {
>     char *tmppath;
>     char *newpath;
>     int fdout;
>+    notmuch_bool_t ret;
>
>     fdout =3D maildir_open_tmp (ctx, dir, &tmppath, &newpath);
>     if (fdout < 0) {
> 	return FALSE;
>     }
>
>+    ret =3D copy_fd_data (fdin, fdout);
>+
>     close (fdout);
>-    unlink (tmppath);
>-    return FALSE;
>+
>+    if (!ret) {
>+	unlink (tmppath);
>+    }
>+
>+    return ret;
> }
>
> int
>--=20
>1.7.4.4
>
>_______________________________________________
>notmuch mailing list
>notmuch@notmuchmail.org
>http://notmuchmail.org/mailman/listinfo/notmuch

--2oS5YaxWCcQjTEyO
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iEYEARECAAYFAlCzlwEACgkQQU4yORhF8iCxXQCdH4l/LZZ3WlIPEf6a3FslsISc
OqkAni9Xj57Fn3fqwix5X3BiJJgB4Nni
=YnyS
-----END PGP SIGNATURE-----

--2oS5YaxWCcQjTEyO--