From: Michal Nazarewicz <mpn@google.com>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch-show: add notmuch-show-auto-mark-read option
In-Reply-To: <874noepwez.fsf@qmul.ac.uk>
Organization: Google Inc
References:
 <7c2931eb4d34ff78e4c73d721bc00dc60d185e6a.1344260116.git.mina86@mina86.com>
	<874noepwez.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/24.1.50.2
	(x86_64-unknown-linux-gnu)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC
Date: Tue, 07 Aug 2012 17:32:51 +0200
Message-ID: <xa1tpq72d8f0.fsf@mina86.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

> On Mon, 06 Aug 2012, Michal Nazarewicz <mpn@google.com> wrote:
>> @@ -1374,9 +1382,11 @@ current thread."
>>    "Are the headers of the current message visible?"
>>    (notmuch-show-get-prop :headers-visible))
>>=20=20
>> -(defun notmuch-show-mark-read ()
>> -  "Mark the current message as read."
>> -  (notmuch-show-tag-message "-unread"))
>> +(defun notmuch-show-mark-read (&optional force)
>> +  "Mark the current message as read if FORCE or
>> +`notmuch-show-auto-mark-read' is non-nil."
>> +  (when (or force notmuch-show-auto-mark-read)
>> +    (notmuch-show-tag-message "-unread")))

Mark Walters <markwalters1009@gmail.com> writes:
> As an alternative approach would allowing a list of tags (or even tag
> changes) to apply when a message is "read" do what you want and be more
> flexible?

Something like the following (not tested)?

From: Michal Nazarewicz <mina86@mina86.com>
Date: Mon, 6 Aug 2012 15:31:20 +0200
Subject: [PATCH] notmuch-show: add notmuch-show-mark-read-tags option

The `notmuch-show-mark-read-tags' lists tags that are to be applied when
message is read.  By default, the only value is "-unread" which will remove
the unread tag.  Among other uses, this variable can be used to stop
notmuch-show from modifying tags when message is shown (by setting the
variable to an empty list).
---
 emacs/notmuch-show.el |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index dcfc190..92a4beb 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -183,6 +183,13 @@ provided with an MLA argument nor `completing-read' in=
put."
 	     notmuch-show-stash-mlarchive-link-alist))
   :group 'notmuch-show)
=20
+(defcustom notmuch-show-mark-read-tags '("-unread")
+  "List of tags to apply when message is read, ie. shown in notmuch-show
+buffer."
+  :type '(repeat string)
+  :group 'notmuch-show)
+
+
 (defmacro with-current-notmuch-show-message (&rest body)
   "Evaluate body with current buffer set to the text of current message"
   `(save-excursion
@@ -1383,8 +1390,9 @@ current thread."
   (notmuch-show-get-prop :headers-visible))
=20
 (defun notmuch-show-mark-read ()
-  "Mark the current message as read."
-  (notmuch-show-tag-message "-unread"))
+  "Apply `notmuch-show-mark-read-tags' to the message."
+  (when notmuch-show-mark-read-tags
+    (apply notmuch-show-tag-message notmuch-show-mark-read-tags)))
=20
 ;; Functions for getting attributes of several messages in the current
 ;; thread.

--=20
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o
..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =
 (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: text/plain


--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBAgAGBQJQITUjAAoJECBgQBJQdR/0sW8P/jSm5/kLi+NroL9AMFuZ46td
dF7PkkzxfjF40Zh/pYR4ismd7VXtj37o89AAp3KNOz5CKu6KtSu692E2BDEV3fWU
eVsXj4qk3yEEs+E82WihuECu5LgBNFcQWAoc+2Fj0ct8isI9HuLF9Onj8e0jLgaY
oOSoUnzCyB5Ga+O5QaM1JgYECV9nIfAibqf+6rhp8+6oZAHYTA5cJdXzDcGhB7V9
d4Fw3/OYQqevMk1HIk27wt5zh322VMTmOaZrcNM8CwwaBttPGgmalcMf4cPTMo/4
v7eCX+gaGMCbj691wKwmmz0UfVgQLfJYrugbgAJZkx0jRvSexBa1+JX8kVJqpAbG
d98Kph8GTHJ7BXw62RLHFTPo8KKP7VzT0WNJ4bYA0QAEU6akLYORtkOUrYtYS4/F
1LK9tICnEvASQlPEcZXx7mh5EaeTuzcKT+ML/Rn0rPVoC8TGybSzrU0B1onNfkBF
79yMql/+Q1DQvw7YY7jYzAQL39u8FKVSVLVt5tHkk64D5+14TneaKZ2J+Fz1tHF/
oZjzvFyWz1Emdh2EiN1UkhyAs57nVIGnQCKoQxoCaB/ZD+XIOYfVuMaP5jnw5O+v
AuP0w3/R2KKvS3eaqFM2dbgviXf1kIjECqhpy73OBLYzhY0kvklYYa0elDcAB3kG
sPAUSa7zu5o67xgyZLMj
=db9A
-----END PGP SIGNATURE-----
--==-=-=--

--=-=-=--