Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 08FE3429E2E for ; Mon, 25 Apr 2011 15:23:43 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.99 X-Spam-Level: X-Spam-Status: No, score=-0.99 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id svcocxlEfiI5; Mon, 25 Apr 2011 15:23:42 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 47BA1431FD0; Mon, 25 Apr 2011 15:23:42 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id C38EF2543F1; Mon, 25 Apr 2011 15:23:41 -0700 (PDT) From: Carl Worth To: Matthieu Lemerre , notmuch@notmuchmail.org Subject: Re: Warning when GMime is parsing broken email addresses In-Reply-To: <87ipzvk2xh.fsf@free.fr> References: <87ipzvk2xh.fsf@free.fr> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Mon, 25 Apr 2011 15:23:41 -0700 Message-ID: <877hai3r82.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2011 22:23:43 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 17 Nov 2010 23:20:26 +0100, Matthieu Lemerre wrote: > Maybe it would also be interesting to add a warning/assertion to check > that all email adresses added to the database are correct email > addresses? I.e. check that the `addr' variable in _index_address_mailbox > always has a @. This check is in fact already done using the function > strchr, but a bad value is explicitly ignored... Hmm... we could add a warning like that. But I don't know how useful it would actually be. (I, for one, am currently not seeing any warnings From=20"notmuch new"---maybe I should fix that...). Since GMime is fixed upstream (as of version 2.4.18) another option would be to simply make the notmuch build system require a sufficiently new version of GMime in order to build. What do you think? =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFNtfRt6JDdNq8qSWgRAtTgAKCBBDkyaEU7ym79uWFuZiZWI/3TQwCeILQR UlcZsUsajIsTmS4FFnpn00c= =o8c+ -----END PGP SIGNATURE----- --=-=-=--