From: David Bremner <david@tethera.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/3] search: Separately report matching and
	non-matching	authors.
In-Reply-To: <1414172643-28270-2-git-send-email-dme@dme.org>
References: <1414172643-28270-1-git-send-email-dme@dme.org>
	<1414172643-28270-2-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.19+27~g29ffde4 (http://notmuchmail.org) Emacs/24.4.1
	(x86_64-pc-linux-gnu)
Date: Sun, 18 Jan 2015 15:19:23 +0100
Message-ID: <871tms9no4.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

David Edmondson <dme@dme.org> writes:

> In addition to the 'authors' attribute of each search result, include
> 'authors_matched' and 'authors_non_matched' attributes. Both
> attributes are always included and are formatted as a list of
> authors. If there are no matching authors, the 'authors_non_matched'
> attribute is set to the empty list.
> ---

It would be nicer if the tests were repaired in the same commit, or
minimally marked broken.

>  static int
>  do_search_threads (sprinter_t *format,
>  		   notmuch_query_t *query,
> @@ -152,6 +253,10 @@ do_search_threads (sprinter_t *format,
>  		format->integer (format, total);
>  		format->map_key (format, "authors");
>  		format->string (format, authors);
> +		if (_enumerate_authors (format, thread) < 0) {
> +		    fprintf (stderr, "Out of memory\n");
> +		    return 1;
> +		}

Maybe I'm just blind, but I don't see how enumerate authors ever returns
anything other than 0.