Date: Sun, 29 Apr 2012 19:02:20 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Subject: Re: [Patch v2 0/3] emacs: allow show to colour based on tags and
 flags
Message-ID: <20120429230220.GO2704@mit.edu>
References: <1335739697-8501-1-git-send-email-markwalters1009@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1335739697-8501-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

I haven't really looked at this series yet, but I do have a quick
high-level question.  Why use separate customization variables for the
colors in search and show mode?  Wouldn't it make more sense to set
the colors just once and use them in both modes?

BTW, I like how this clearly distinguishes tags and flags.  I wonder
if we could transition to flags for some information that's current
shoe-horned into tags but actually represents immutable information
about a message (attachment, signed, and encrypted or so).

My one concern is that there's a common tag called "flagged", so this
might be overloading terminology.

Quoth Mark Walters on Apr 29 at 11:48 pm:
> This is a rebased (but otherwise unchanged) version of
> id:"1334431301-27303-1-git-send-email-markwalters1009@gmail.com".
> 
> It's probably too late for 0.13 but in case anyone would like to look
> at it this version applies cleanly to master so should be easier to
> test.
> 
> The first two patches are basically David Edmondson's patch
> id:"1325006003-27152-1-git-send-email-dme@dme.org".
> 
> Best wishes
> 
> Mark
> 
> 
> Mark Walters (3):
>   emacs: Move colour line from search to lib
>   emacs: Add `notmuch-show-line-faces' and apply it.
>   emacs: allow notmuch-show-line-faces to use flags for colouring
> 
>  emacs/notmuch-lib.el  |   18 ++++++++++++++++++
>  emacs/notmuch-show.el |   44 ++++++++++++++++++++++++++++++++++++++++----
>  emacs/notmuch.el      |   15 +--------------
>  3 files changed, 59 insertions(+), 18 deletions(-)