Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3F959431FD0 for ; Thu, 8 Dec 2011 00:49:59 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fG2DrjHNte-P for ; Thu, 8 Dec 2011 00:49:58 -0800 (PST) Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B30AB431FB6 for ; Thu, 8 Dec 2011 00:49:57 -0800 (PST) Received: from pps.filterd (mail-gw3 [127.0.0.1]) by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pB88njB3025703; Thu, 8 Dec 2011 10:49:45 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by mail-gw3.nixu.fi with ESMTP id 114cs0s1nj-1 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Thu, 08 Dec 2011 10:49:45 +0200 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id pB88nhVR023924; Thu, 8 Dec 2011 10:49:44 +0200 From: Tomi Ollila To: Jameson Graef Rollins , Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH v3 0/2] notmuch hooks In-Reply-To: <87ipls81za.fsf@servo.finestructure.net> References: <7fbe6befcf31881a9bca672f55b93501249a220c.1322859389.git.jani@nikula.org> <87hb1dru9c.fsf@servo.finestructure.net> <87iplsb23a.fsf@nikula.org> <87ipls81za.fsf@servo.finestructure.net> User-Agent: Notmuch/0.10.2+70~gf0e0053 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110, 1.0.211, 0.0.0000 definitions=2011-12-08_02:2011-12-08, 2011-12-08, 1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1012030000 definitions=main-1112080008 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2011 08:49:59 -0000 On Wed, 07 Dec 2011 14:13:13 -0800, Jameson Graef Rollins wrote: > On Wed, 07 Dec 2011 21:42:33 +0200, Jani Nikula wrote: > > I wonder, though, whether the samples should be created only when > > creating the database, or whenever the hooks directory does not exist? > > The latter, I guess. Otherwise existing notmuch users would hardly get > > the sample hooks. > > I agree, the later would be better. notmuch new should just create the > hooks directory (and example scripts) if they don't already exist. +1 > > I also think it's nice to have the scripts not executable to begin with, > and the hook runner only executes the script if they are executable. If the hooks are named as 'pre-new.sample' and 'post-new.sample' and executable then users need just copy the file and start editing (and not remember to do any chmod's)... ... this is the way it seems to be in .git/hooks -- I tested copy -- permission bits seems to follow (filtered by umask). > jamie. Tomi