Date: Wed, 18 Jan 2012 13:44:08 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Pieter Praet <pieter@praet.org>
Subject: Re: [PATCH v4] emacs: logically group def{custom,face}s
Message-ID: <20120118184408.GD16740@mit.edu>
References: <871ur02awi.fsf@praet.org>
	<1326710313-21417-1-git-send-email-pieter@praet.org>
	<20120116191622.GB16740@mit.edu> <87ipk98h5d.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ipk98h5d.fsf@praet.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

Quoth Pieter Praet on Jan 18 at 11:00 am:
> On Mon, 16 Jan 2012 14:16:22 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > LGTM.
> > 
> > Quoth Pieter Praet on Jan 16 at 11:38 am:
> > > - Add `notmuch-send' to the `message' group, as per Austin's
> > >   recommendation [1].
> > 
> > This is actually the reverse of what I was suggesting (though is also
> > reasonable).  Since notmuch uses message-mode, I was saying that the
> > notmuch group (or the notmuch-send group) should link to the message
> > group.  That way, if you customize-group notmuch, you get all of the
> > options that affect notmuch, even those that aren't strictly notmuch
> > variables.
> 
> Sorry, failed to mention;  I tried that, but the additional
> 
>   :link '(custom-group-link :tag "Message" message)
> 
> didn't seem all that useful compared to (or combined with)
> adding `message' as parent group to `notmuch-send':
> 
>   #+begin_example
>     Parent groups: Message Notmuch
> 
>     /- Notmuch Send group: Sending messages from Notmuch.--------------------\
>           State: something in this group has been changed outside customize.
>   #+end_example
> 
> vs.
> 
>   #+begin_example
>     Parent groups: Message Notmuch
> 
>     /- Notmuch Send group: Sending messages from Notmuch.--------------------\
>           State: something in this group has been changed outside customize.
>           See also Message.
>   #+end_example
> 
> ... so I ripped it out again.  Should I add it back?

Hmm.  You're right that the :link doesn't do much.

One other possibility to consider is
  (custom-add-to-group 'notmuch-show 'message 'custom-group)
or even
  (custom-add-to-group 'notmuch 'message 'custom-group)