Message-ID: <4DE51768.3070409@fifthhorseman.net>
Date: Tue, 31 May 2011 12:29:28 -0400
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.9.2.15) Gecko/20110402 Icedove/3.1.9
MIME-Version: 1.0
Subject: Re: compile error of current git on F15
References: <m3d3j1uz2i.fsf@x201s.gr8dns.org>
	<8762osjagp.fsf@servo.factory.finestructure.net>
In-Reply-To: <8762osjagp.fsf@servo.factory.finestructure.net>
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature";
	boundary="------------enig52AFF77078BC5FF69C666729"
Cc: notmuch <notmuch@notmuchmail.org>, Jeffrey Stedfast <fejj@novell.com>
Precedence: list
Reply-To: notmuch <notmuch@notmuchmail.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig52AFF77078BC5FF69C666729
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

i'm CC'ing the upstream lead developer of gmime here to see if he has
any thoughts (and can correct any misrepresentations from me) -- Hi Jeffr=
ey!

On 05/30/2011 02:43 PM, Jameson Graef Rollins wrote:
> On Sun, 29 May 2011 11:44:05 -0700, Dirk Hohndel <hohndel@infradead.org=
> wrote:
>> CC -O2 notmuch-reply.o
>> notmuch-reply.c: In function =E2=80=98notmuch_reply_command=E2=80=99:
>> notmuch-reply.c:658:3: error: unknown type name =E2=80=98GMimeSession=E2=
=80=99
>> notmuch-reply.c:659:3: warning: passing argument 1 of =E2=80=98g_mime_=
gpg_context_new=E2=80=99 from incompatible pointer type [enabled by defau=
lt]
>> /usr/include/gmime-2.6/gmime/gmime-gpg-context.h:64:21: note: expected=
 =E2=80=98GMimePasswordRequestFunc=E2=80=99 but argument is of type =E2=80=
=98int *=E2=80=99
>> make: *** [notmuch-reply.o] Error 1
>>
>> This seems to have been introduced in Jameson's crypto patch series...=

>>
>> ./configure shows:
>>
>> Checking for Xapian development files... Yes (1.2.4).
>> Checking for GMime development files... Yes (gmime-2.6).
>> Checking for Glib development files (>=3D 2.14)... Yes.
>=20
> Hey, Dirk.  Looks like you're using gmime-2.6, which is something I've
> never looked at, and it looks like there are API changes.  This of
> course doesn't help you, Dirk, but this probably means we should requir=
e
> libgmime-2.4, at least until we can figure out how to support both
> versions, which I'm not sure how to handle.
>=20
> Dirk, just out of curiosity, what system are you running that is
> provides gmime 2.6?

F15 probably means Fedora 15.

gmime 2.6 has not been released yet; gmime 2.5 is the development
version (which itself has an unstable API); the project uses the
even=3Dstable/odd=3Dunstable version numbering scheme.

As the dev version, gmime 2.5 identifies itself as 2.6.  I'm not sure i
can justify this decision.  Jeffrey, can you explain?

If F15 does not have gmime 2.4 available in it, it's possible that it
may not be able to build notmuch :/

I don't think that notmuch should attempt to target a library with an
unstable API.  But if anyone is interested in preparing for the gmime
2.6 release (maybe jeffrey can hint at the timeline for us) may want to
prepare changesets that #ifdef the relevant code depending on the API
version.

Once gmime 2.6 is released, we'll need to decide if we want to remain
compatible with the old API as well, or just require gmime 2.6; but i
don't think we need to cross that bridge right now.

Regards,

	--dkg


--------------enig52AFF77078BC5FF69C666729
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQJ8BAEBCgBmBQJN5RdoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQwRUU1QkU5NzkyODJEODBCOUY3NTQwRjFD
Q0QyRUQ5NEQyMTczOUU5AAoJEMzS7ZTSFznpNRwP+gI7Hwd1xHpF+jNlMBeNymUg
cv/UUql61CGmMORZSUNIK0WbnxLAQLPUu4QpZyiNG3KKFpIJiopMDDnUA/QM3O7m
yDs2kG7PXcRLNVq+hSuUbJp8hXMkFMP6fnnRA7+xvBFkPJ/EJcUEWcBjK9A5/4YQ
Nf1BdXQYaz+Ih2SpAqSj9fGmEmQkIcO0kYu0O52ETHaZbBASIn1wo5cudQb9hS3A
k9TDLtuNGHxDwKMx3WwxxuRaydqSlS7hqjogcF/VY7Kkq2DfxsfraCiSnmgU+eje
FqanyStZpDULpFaWleVHtmeGsecQIorXdnOJX5aKbQpn19d9jU8XLAEXYsZ3wqOs
okz0ZpzNavL5NexKE5+cUs5fLJt4S8G9oSBklwd/qpo2ztzBCOZNnWFd3G2cQ7Pc
awN+iRRPg1pGSzI98xMUV6vDTPN9eujnaYQvG+T5aB3j0oTzafKN41Vp8TMtwfIo
FS8/TA/XJQRRTmAAvUpOf4V49+s48TklYA67Tbzt9rzWzLKTy7Ts8Mx/lp0WbRIu
uBcOVrnbHMphK6Up4Xr3PPGwuVR4Fr+OLH4Xdldxc6B80V1QRFPos9beL/RTAEg3
FnGMs2X6/qeaCgggmIEKhCIkHeReBHQqwK+5R+SL6iDkcNcF82lGEntTdWjJpG2t
SicX22xZ8YYbC3GSdPTt
=51JQ
-----END PGP SIGNATURE-----

--------------enig52AFF77078BC5FF69C666729--