Date: Mon, 19 Jan 2015 08:55:35 -0800
From: "W. Trevor King" <wking@tremily.us>
To: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH v4] nmbug: Add an 'init' command
Message-ID: <20150119165535.GR4613@odin.tremily.us>
References:
 <b3d22d1d587a626e91f536f6393e476a41de84c9.1421627321.git.wking@tremily.us>
	<m2oapvf6kv.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="phbq2bkSb+hZnunM"
Content-Disposition: inline
In-Reply-To: <m2oapvf6kv.fsf@guru.guru-group.fi>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--phbq2bkSb+hZnunM
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 19, 2015 at 11:44:16AM +0200, Tomi Ollila wrote:
> $ python2.7 devel/nmbug/nmbug init
> Reinitialized existing Git repository in /home/too/.nmbug/
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> user.name not defined
> [u'git', u'--git-dir', u'/home/too/.nmbug', u'commit', u'--allow-empty',
> u'-m', u'Start a new nmbug repository'] exited with 1
> zsh: exit 1     python2.7 devel/nmbug/nmbug init
>=20
> This is due to my default /path/to/git-templates/pre-commit
> forbidding commits unless I've configured user.name & user.email for
> that particular repository....
>=20
> I guess there is not much one can do to handle users' mystic global
> hooks -- I'll look (later) whether e.g. '--no-hooks' parameter could
> be given to nmbug from command line...
>=20
> ... Ok, it was --no-verify and patching that to the command line
> worked -- git complained that "Your name and email address were
> configured automatically based on your username and hostname..."=E2=80=A6

Hmm.  My initial feeling is that if your pre-commit hook doesn't want
you to commit, we should respect that.  Although I'm not sure how to
handle this case for folks like you that don't define a global
username or email address.  Possibilities:

* Drop the empty commit from =E2=80=98nmbug init=E2=80=99 and teach =E2=80=
=98nmbug log=E2=80=99,
  =E2=80=98status=E2=80=99, =E2=80=98commit=E2=80=99, etc. to handle the =
=E2=80=9Cwe don't have any commits
  yet=E2=80=9D case?  That gives you time between the init and first commit=
 to
  go into the repository and setup your username and email address by
  hand.  This would be the most work, but gives us a more native
  solution (=E2=80=98nmbug init=E2=80=99 maps more directly to =E2=80=98git=
 init=E2=80=99).

* Adjust the syntax to:

    nmbug init -- {arguments passed through to =E2=80=98git commit=E2=80=99}

  so you could run:

    nmbug init -- --author 'A U Thor <author@example.com>'

  or:

    nmbug init -- --no-verify

  this works as long as the tweak you need is accessible from a =E2=80=98git
  commit=E2=80=99 argument (I guess --no-verify covers us there).

> =E2=80=A6 but commit succeeded :).

=46rom the template pre-commit.sample:

  The hook should exit with non-zero status after issuing an
  appropriate message if it wants to stop the commit.

so you should check that your hook is doing that if you expect to
abort commits it doesn't like ;).

> I think it should be checked so that init on already-existing
> repository does not succeed.

Good point.  I've added:

  if _os.path.exists(NMBGIT):
      raise ValueError('NMBGIT path ({!r}) already exists'.format(NMBGIT))

for v5.

Cheers,
Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--phbq2bkSb+hZnunM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUvTcFAAoJEG8/JgBt8ol8nwMP/RgEvEO7EnDq1/CjsOjWvN+8
DzTPD3UIbahyytZr/wV+96rTO/z8X2Uj3GW3imSP3Moz9UP+v9tbzebRmwqFA+Nn
o8cA4meUGdlfIl8+2DwDKKh9brntHabVrhmub8Yz10b4zlRXuNP1YOkOE2v1MRxI
6w6DLQHPBuqWz79DnSl1x9ENfZ0f2lTey7nPbwnQ1KvnbcQKmDIMftX3V96bxUQ2
8UJRCFIGoshOeZLUaf27czxP7gguV6vmKlRDPNl98VqEG6oYAkDZ5xxNfM2Nxqan
ZfzJA6vMTmuaAW9y8ReVlKyqaLUz2mEznR8a6uxIBKAc8561r3GfzXE+ggzaG1eq
rzDEzzPtsCZ8iaik0mFP8HZ/lmsXI4eQG2/TtoRB8qx/wfEwDZUaUSS+00MQJaC2
1AjEeQ9Om+Onm1xFp8lFbZ5fjd1NbUDEBemgzol7vSueC0qM0pQWEP3cIAzTTafy
xeb/HxdCduRvp/cy+yjDPgUWyWGGGBIxqKkSD+REBKKBGBUKHfjbDjknusLqYgdD
snpQGA/Ic1RL40OTXaF2toxDlUeycXOl0ggI1CX0DW9eFfMDHxdzY1OX0D/yQo+V
ToNGZKp/4BdhxYm3Tja5k8e8c8BXns14TSCS5E1o/WFF8UHEaGrNO48MjEzPA2Cj
No9YFjQX0kOnKvkjQ/TJ
=C9ca
-----END PGP SIGNATURE-----

--phbq2bkSb+hZnunM--