From: Mark Walters <markwalters1009@gmail.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el
In-Reply-To: <87bnyzoqq9.fsf@zancas.localnet>
References: <87y5sipcjn.fsf@qmul.ac.uk>
	<1329900529-16295-1-git-send-email-markwalters1009@gmail.com>
	<87bnyzoqq9.fsf@zancas.localnet>
User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Sun, 26 Jan 2014 19:37:27 +0000
Message-ID: <8738kaa614.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


I don't have anything older than 23.4 anymore so I am afraid I can't
test. My recollection is that I upgraded to 23.4 the problem went away
so I forgot about it. 

(I couldn't see easily what version of emacs debian stable has now as
seemed to be called 45.)

Best wishes

Mark


On Sat, 25 Jan 2014, David Bremner <david@tethera.net> wrote:
> Mark Walters <markwalters1009@gmail.com> writes:
>
>> ido-completing-read is used in notmuch-mua.el without any
>> initialization.  This should work but a bug (emacs bug #3247) in some
>> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs
>> to get stuck in the mini-buffer. This tests to see if ido-mode has
>> been initialized and if not calls it. This avoids the bug for these
>> older versions of emacs.
>>
>> This is the only place that ido-completing-read is used so an alternative 
>> would be to replace ido-completing-read by completing-read but cworth 
>> expressed a preference for the ido version in 
>> id:"87wrhfvk6a.fsf@yoom.home.cworth.
>
> This patch was tagged wip, but then there was no progress ;).  It still
> applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor
> emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can
> confirm it actually fixes the bug there.
>
> I propose we either apply the patch or ::wontfix the bug.
>
> cheers,
>
> d