From: Aaron Ecay <aaronecay@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1] emacs: Allow part preferences to depend on message
 content.
In-Reply-To: <1452864898-9719-2-git-send-email-dme@dme.org>
References: <1452864898-9719-1-git-send-email-dme@dme.org>
 <1452864898-9719-2-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.21+33~g570c0ae (http://notmuchmail.org) Emacs/25.0.50.2
 (x86_64-unknown-linux-gnu)
Mail-Followup-To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Date: Tue, 19 Jan 2016 13:41:34 +0000
Message-ID: <87k2n5hek1.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

Hi David,

2016ko urtarrilak 15an, David Edmondson-ek idatzi zuen:
>=20
> Currently the preference for which sub-part of a multipart/alternative
> part is shown is global. Allow to the user to override the settings on a
> per-message basis by providing two new options:
>=20
>   - the ability to call a function that has access to the message to
>     return the discouraged type list,
>   - a simple evaluation environment to reduce the need for most users to
>     write their own function.
>=20
> The original approach is retained as the default.
> ---
>  emacs/notmuch-lib.el  | 39 +++++++++++++++++++++++++++++++++++----
>  emacs/notmuch-mua.el  |  2 +-
>  emacs/notmuch-show.el |  2 +-
>  3 files changed, 37 insertions(+), 6 deletions(-)
>=20
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 89c01a5..2b9d108 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -520,11 +520,42 @@ This replaces spaces, percents, and double quotes i=
n STR with
>      "multipart/related"
>      ))
>=20=20
> -(defun notmuch-multipart/alternative-choose (types)
> -  "Return a list of preferred types from the given list of types"
> +(defun notmuch-multipart/alternative-determine-discouraged-1 (msg direct=
ive)
> +  (let* ((headers (plist-get msg :headers))
> +	 ;; Headers that we make available:
> +	 (from (plist-get headers :From))
> +	 (subject (plist-get headers :Subject))
> +	 (to (plist-get headers :To))
> +	 (cc (plist-get headers :Cc)))
> +
> +    (eval directive)))

This code is not compatible with lexical binding in emacs >=3D 24, which I
assume notmuch will eventually want to adopt.  What=E2=80=99s so bad about
writing a function?

--=20
Aaron Ecay