Resent-To: notmuch@notmuchmail.org
Resent-From: David Bremner <david@tethera.net>
Resent-Date: Thu, 09 Jun 2016 12:44:21 -0300
Resent-Message-ID: <87wplyxt7u.fsf@tesseract.cs.unb.ca>
Subject: Bug#826843: Calls to notmuch_database_add_message() after
 notmuch_database_close() crash
Reply-To: Lars Luthman <deb-bugs@larsluthman.net>, 826843@bugs.debian.org
Also-Resent-From: Lars Luthman <deb-bugs@larsluthman.net>
Also-Resent-To: debian-bugs-dist@lists.debian.org
Also-Resent-CC: Carl Worth <cworth@debian.org>
Also-Resent-Date: Thu, 09 Jun 2016 11:03:01 +0000
Also-Resent-Message-ID: <handler.826843.B.146547014919804@bugs.debian.org>
Message-ID: <1465470142.3501.10.camel@larsluthman.net>
From: Lars Luthman <deb-bugs@larsluthman.net>
To: submit@bugs.debian.org
Date: Thu, 09 Jun 2016 13:02:22 +0200
Content-Type: multipart/mixed; boundary="=-6lshnzaqf1KN2rKF0TKb"
Mime-Version: 1.0
Precedence: list


--=-6lshnzaqf1KN2rKF0TKb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Package: libnotmuch-dev
Version: 0.18.2-1
Severity: important

In the API documentation for notmuch_database_close() it says:

 * After notmuch_database_close has been called, calls to other
 * functions on objects derived from this database may either behave
 * as if the database had not been closed (e.g., if the required data
 * has been cached) or may fail with a
 * NOTMUCH_STATUS_XAPIAN_EXCEPTION.

However, if you call notmuch_database_close() on a database and then
call notmuch_database_add_message(), it doesn't fail nicely with a
NOTMUCH_STATUS_XAPIAN_EXCEPTION, it segfaults.

This should either be fixed so it doesn't crash, as documented, or the
documentation should be changed to describe which functions are unsafe
to call after notmuch_database_close().

I'm attaching a small C program to reproduce the bug. It crashes with
the following backtrace:

(gdb) bt
#0  0xb71f3f27 in Xapian::WritableDatabase::begin_transaction(bool) ()
   from /usr/lib/sse2/libxapian.so.22
#1  0xb779480d in notmuch_database_begin_atomic ()
   from /usr/lib/i386-linux-gnu/libnotmuch.so.3
#2  0xb7794fa0 in notmuch_database_add_message ()
   from /usr/lib/i386-linux-gnu/libnotmuch.so.3
#3  0x080488d3 in add_new_email (db=0x82b5610, 
    filename=0x8048b51 "/new-mail-2@example.net:2,", content=0x8048b30
"hello")
    at notmuchcrash.c:27
#4  0x080489d7 in main () at notmuchcrash.c:52


Installed version of libxapian22: 1.2.19-1+deb8u1


-- System Information:
Debian Release: 8.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.16.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libnotmuch-dev depends on:
ii  libnotmuch3  0.18.2-1

libnotmuch-dev recommends no packages.

libnotmuch-dev suggests no packages.

-- no debconf information

--=-6lshnzaqf1KN2rKF0TKb
Content-Disposition: attachment; filename="notmuchcrash.c"
Content-Type: text/x-csrc; name="notmuchcrash.c"; charset="UTF-8"
Content-Transfer-Encoding: base64

LyogQ29tcGlsZSB3aXRoOgogICBnY2MgLWcgLXN0ZD1jOTkgLVdhbGwgLVdlcnJvciAtbyBub3Rt
dWNoY3Jhc2ggLWxub3RtdWNoIG5vdG11Y2hjcmFzaC5jCiovCgojZGVmaW5lIF9QT1NJWF9DX1NP
VVJDRSAyMDA4MDlMCgojaW5jbHVkZSA8c3RkaW8uaD4KI2luY2x1ZGUgPHN0ZGxpYi5oPgojaW5j
bHVkZSA8c3RyaW5nLmg+CgojaW5jbHVkZSA8bm90bXVjaC5oPgoKCiNkZWZpbmUgRElFKG1zZykg
ZG8geyBwZXJyb3IobXNnKTsgZXhpdChFWElUX0ZBSUxVUkUpOyB9IHdoaWxlICgwKQoKCnZvaWQg
YWRkX25ld19lbWFpbChub3RtdWNoX2RhdGFiYXNlX3QqIGRiLAogICAgICAgICAgICAgICAgICAg
Y2hhciBjb25zdCogZmlsZW5hbWUsIGNoYXIgY29uc3QqIGNvbnRlbnQpIHsKICBjaGFyIG1haWxf
cGF0aFs2NF07CiAgc3RyY3B5KG1haWxfcGF0aCwgbm90bXVjaF9kYXRhYmFzZV9nZXRfcGF0aChk
YikpOwogIHN0cmNhdChtYWlsX3BhdGgsIGZpbGVuYW1lKTsKICBGSUxFKiBtZiA9IGZvcGVuKG1h
aWxfcGF0aCwgIncrIik7CiAgaWYgKCFtZikgRElFKCJGYWlsZWQgdG8gb3BlbiBtYWlsIGZpbGUi
KTsKICBpZiAoZndyaXRlKGNvbnRlbnQsIHN0cmxlbihjb250ZW50KSwgMSwgbWYpICE9IDEpCiAg
ICBESUUoIkZhaWxlZCB0byB3cml0ZSBtYWlsIik7CiAgaWYgKGZjbG9zZShtZikpIERJRSgiRmFp
bGVkIHRvIGNsb3NlIGZpbGUiKTsKICBpZiAobm90bXVjaF9kYXRhYmFzZV9hZGRfbWVzc2FnZShk
YiwgbWFpbF9wYXRoLCBOVUxMKSAhPQogICAgICBOT1RNVUNIX1NUQVRVU19GSUxFX05PVF9FTUFJ
TCkKICAgIERJRSgiU29tZXRoaW5nIHdlbnQgd3Jvbmcgd2hlbiBhZGRpbmcgdGhlIGVtYWlsIik7
Cn0KCgppbnQgbWFpbigpIHsKCiAgLyogQ3JlYXRlIG5ldyBkYXRhYmFzZS4gKi8KICBjaGFyIGRi
X3BhdGhbMzJdOwogIHN0cmNweShkYl9wYXRoLCAiL3RtcC9ub3RtdWNoY3Jhc2gtWFhYWFhYIik7
CiAgaWYgKCFta2R0ZW1wKGRiX3BhdGgpKSBESUUoIkZhaWxlZCB0byBjcmVhdGUgdW5pcXVlIGRp
cmVjdG9yeSIpOwogIG5vdG11Y2hfZGF0YWJhc2VfdCogZGI7CiAgaWYgKG5vdG11Y2hfZGF0YWJh
c2VfY3JlYXRlKGRiX3BhdGgsICZkYikpIERJRSgiRmFpbGVkIHRvIGNyZWF0ZSBkYXRhYmFzZSIp
OwoKICAvKiBUaGlzIGRvZXNuJ3QgaGF2ZSB0byBiZSBhIHZhbGlkIGVtYWlsLCBpdCB3aWxsIGNy
YXNoIGVpdGhlciB3YXkuICovCiAgY2hhciBjb25zdCogbWFpbF9kYXRhID0gImhlbGxvIjsKCiAg
LyogRmlyc3QsIHRyeSB0byBhZGQgYSBmaWxlIGJlZm9yZSBjbG9zaW5nLiAqLwogIGFkZF9uZXdf
ZW1haWwoZGIsICIvbmV3LW1haWwtMUBleGFtcGxlLm5ldDoyLCIsIG1haWxfZGF0YSk7CiAgCiAg
LyogQ2xvc2UgdGhlIGRhdGFiYXNlLiAqLwogIG5vdG11Y2hfZGF0YWJhc2VfY2xvc2UoZGIpOwoK
ICAvKiBOb3cgdHJ5IGFnYWluLiBUaGlzIHdpbGwgY3Jhc2guICovCiAgYWRkX25ld19lbWFpbChk
YiwgIi9uZXctbWFpbC0yQGV4YW1wbGUubmV0OjIsIiwgbWFpbF9kYXRhKTsKICAKICByZXR1cm4g
MDsKfQo=


--=-6lshnzaqf1KN2rKF0TKb--