From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
	David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: optionally print subtest number
In-Reply-To: <87hb14ukbc.fsf@gmail.com>
References: <1323806207-31888-1-git-send-email-david@tethera.net>
	<87zkew2jtu.fsf@servo.finestructure.net>
	<87d3bsjc1z.fsf@zancas.localnet> <87hb14ukbc.fsf@gmail.com>
User-Agent: Notmuch/0.10.2+93~ga124635 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 13 Dec 2011 15:35:53 -0800
Message-ID: <87pqfs2gfa.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 14 Dec 2011 03:24:23 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> BTW I have some plans to introduce optional explicit test ids that can
> be used for inter-test dependencies.  E.g.:
>=20
>   test_begin_subtest test-id-1 "A subtest"
>   ....
>   ;; in another test requre that test-id-1 passed
>   test_require_subtest test-id-1

Would the required test need to be listed twice, both on the
begin_subtest line *and* in the require_subtest line?

And again, why would the test id have to be any different that the
existing test names?  The tests already have names, so I don't
understand why we would want to introduce some other kind of
identification.  Seems like it's just going to add extra confusion.

And speaking of which, I sometimes worry that the test infrastructure
itself is getting too complicated.  Pretty soon we're going to need
tests for the tests.  I don't necessarily see the need to all of these
extra features in the test suite, so I worry that it's just making
everything harder to debug.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJO5+FZAAoJEO00zqvie6q8lhoP/jhjExA5NfqGXGNEuud6+EiH
X4UAMav/6kwZYJHV8meAm9QQOsUDUW9gVQY0zrcslu2A+NqWt57eKafCHkQW1yDU
1C63XDlR9pelN2HdFhyzPlfXBTn++MfANZQ+QqXb+y+v1htem3GKszbXIXxPOjn2
A1kjYYSvJAhxYpQ/UrRSGUc4MaCbLRylggRDoqonrGtZCi7hKQh6QErPt1J/iPp3
7dEV71sjQsTfl27OUEGnWIdFKUDRRodqyiV6lbeI2xLNcsKAmXyiI4v31PGs2aH2
3XwpegitBN34Q+GBg/EfAIRyowrdluBCBx9cyB1VMDQF/VLnmjWWngVUwN5x8H55
RjUfu/ze6g8FOiSEzzODF9g8YwQefy00lGs+JUaNgVcCFI1mivdrQcPsE1jV2Pb9
cKcfa+9Mc07+aYgAM1FyiIbnWVgl12kLknW5UYviVpQTb4CsninYeMog2YbZg7Ar
EZnoGpN7fzWAsvNd/Usy6dZGPZ2FBgFOajUC54J1Z1VDjFNpjfgG2teFhiNU3aiG
tW0TUOxQh1fzDrqsjHiaMAuBfNGYOcJr0+UsXG7mKbe/O6WuTyNEyKi55ph11Xj+
0ml6DBBbaqSrqVG5JTfxG1y+9DTd/58LSCscO46sE1vL3B6fRaBH3/x3mV117bo+
3VKbP0Wd4AzVf7lvcFju
=PfdM
-----END PGP SIGNATURE-----
--=-=-=--