Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Kazuo Teramoto <kaz.rag@gmail.com>
To: David Bremner <david@tethera.net>,  notmuch@notmuchmail.org
References: <877h1e6r9d.fsf@zancas.localnet>
	<1325282290-29565-1-git-send-email-kaz.rag@gmail.com>
	<1325282290-29565-2-git-send-email-kaz.rag@gmail.com>
	<87k45d5u0w.fsf@zancas.localnet>
In-Reply-To: <87k45d5u0w.fsf@zancas.localnet>
Date: Sat, 31 Dec 2011 03:07:16 -0000
Message-ID: <20111231030716.792.79379@sophie>
Subject: Re: [PATCH 1/2] lib: Remove unnecessary checks when calling
	g_mime_init
Date: Sat, 31 Dec 2011 01:07:16 -0200
Precedence: list

On 2011-12-31T00:55:59, David Bremner wrote:

>On Fri, 30 Dec 2011 19:58:09 -0200, Kazuo Teramoto <kaz.rag@gmail.com> wro=
te:
>> g_mime_init already check for multiple initializations.
>> ---
>>  lib/index.cc       |    4 ----
>>  lib/message-file.c |    4 ----
>>  2 files changed, 0 insertions(+), 8 deletions(-)
>
>Is this needed to fix the bug? It seems less futureproof to rely on
>gmime to check for double initialization if we don't have to.
>

No its not. But if you decide to push only the other part we probably
need to add the initialization check to it, for consistency. I can send
another patch, would you like it?